Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes preview issues on lily. #1599

Merged
merged 1 commit into from May 28, 2019

Conversation

Projects
None yet
3 participants
@bran
Copy link
Contributor

commented May 16, 2019

Original Issue, this PR is going to fix: #1598

Make sure these boxes are checked before asking for review of your pull request - thank you!

If there is a new feature or this is a bug fix - use 8.x-2.x branch. We'll tag for release if the bug is critical asap or tag for release next bug fix release until critical issue arrived.

Steps for review

  • Try to preview a landing node (on a site that uses lily), should work.

General checks

  • [X ] All coding styles are fulfilled and there are no any issues reported by CodeSniffer CI.
    CI code sniffer errors
  • [X ] All tests are running and there are no failed tests reported by CI.
    Behat test results
  • [X ] Documentation has been updated according to PR changes.
  • [ X] Steps for review have been provided according to PR changes.
    Steps for review
  • [X ] Make sure you've provided all necessary hook_update_N to support upgrade path.
  • [X ] Make sure your git email is associated with account on drupal.org, otherwise you won't get commits there.
    drupal.org email
  • [X ] If you would like to get credits on drupal.org, check documentation.

Thank you for your contribution!

@gundevel

This comment has been minimized.

Copy link
Collaborator

commented May 16, 2019

Can one of the admins verify this patch? Use "o+k to test" or ''t+est this please" for manual build execution.

@podarok

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

ok to test

@gundevel

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

Build comment file:

Environment Link
Fresh OpenY installation - Rose theme http://openy.cibox.tools/build1604
Fresh OpenY installation - Lily theme http://lily.openy.cibox.tools/build1604
Upgraded(upgrade path) installation http://upgrade.openy.cibox.tools/build1604
Installation process http://install.openy.cibox.tools/build1604/install.php

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://openy.cibox.tools:8080/job/PR_BUILDER_COMPOSER/1604/

@gundevel

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

Acessibility Sniffer: front page checking WCAG2AA http://openy.cibox.tools/build1604/frontWCAG2AAhtmlcs.txt
Acessibility Sniffer: join page checking WCAG2AA http://openy.cibox.tools/build1604/joinWCAG2AAhtmlcs.txt
Acessibility Sniffer: locations page checking WCAG2AA http://openy.cibox.tools/build1604/locationsWCAG2AAhtmlcs.txt
Acessibility Sniffer: schedules page checking WCAG2AA http://openy.cibox.tools/build1604/schedulesWCAG2AAhtmlcs.txt
Acessibility Sniffer: blog page checking WCAG2AA http://openy.cibox.tools/build1604/blogWCAG2AAhtmlcs.txt

@podarok podarok merged commit ddc616f into ymcatwincities:8.x-2.x May 28, 2019

2 of 5 checks passed

Accessibility tests Accessibility tests run has been failed.
Details
CIBox tests Tests run has been failed.
Details
ci/circleci CircleCI is running your tests
Details
DeepCode Found no critical issues.
Details
default Merged build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.