Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

issue#62 fixed submit filter button in modal for tablet screen #63

Merged
merged 2 commits into from
Jun 24, 2021
Merged

issue#62 fixed submit filter button in modal for tablet screen #63

merged 2 commits into from
Jun 24, 2021

Conversation

aleevas
Copy link
Contributor

@aleevas aleevas commented May 20, 2021

That should fix issue that described in #62

Copy link
Contributor

@duozersk duozersk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to apply the similar fix to the "filters-header" classes.

Copy link
Contributor

@duozersk duozersk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be careful and attentive to details.

@@ -236,6 +240,12 @@ export default {
!this.isEqual(this.selectedLocations, this.initialLocations) ||
!this.isEqual(this.selectedActivities, this.initialActivities)
)
},
headerClasses() {
return this.bsVersion === 4 ? 'd-none d-lg-flex' : 'hidden-md hidden-lg'
Copy link
Contributor

@duozersk duozersk May 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 'hidden-xs hidden-sm' for BS 3...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duozersk thanks for notice
fixed.
Please check it again

@duozersk duozersk linked an issue May 25, 2021 that may be closed by this pull request
@duozersk duozersk added the bug Something isn't working label May 25, 2021
@podarok podarok merged commit 1134c82 into ymcatwincities:4.x Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AF4] Can't apply filter in modal on tablet screen
3 participants