Yaron Minsky yminsky

Organizations

@janestreet @realworldocaml
@yminsky
Time.of_string should return a Result.t
yminsky commented on issue github/linguist#2208
@yminsky

There are lots of repos that still seem to be wrong. For example, near and dear to my heart: https://github.com/janestreet/core_kernel is supposedl…

yminsky commented on pull request janestreet/core_kernel#8
@yminsky

Should we close this PR? I wonder if there's still an issue here to solve. I don't really understand the issues here, but @hhugo is working on gett…

@yminsky
loading bignum in utop fails
@yminsky
New comment on block [block-idm181621175824]
yminsky commented on issue realworldocaml/book#2695
@yminsky

True, but the book is in general presenting the Core API style.

yminsky commented on pull request ocaml/ocaml#147
@yminsky

Any further thoughts on this PR, and whether it can be accepted upstream?

yminsky commented on pull request ocaml/ocaml#147
@yminsky

Sorry. Stupid mistake. Fixed now.

@yminsky
yminsky commented on pull request ocaml/ocaml#147
@yminsky

@edwintorok That's a really intriguing idea. Maybe this is something that could be hosted under the aegis of ocaml.org (at github.com/ocaml), since…

yminsky commented on pull request ocaml/ocaml#147
@yminsky

I'm frankly a little uneasy with your Result package grabbing the toplevel name of Result. I agree that Pervasives_result seems fine for this case,…

yminsky commented on pull request ocaml/ocaml#147
@yminsky

Here's a minimal compatibility package: https://github.com/janestreet/result Responding to Alain: with respect to this PR, I think the compatibilit…

yminsky commented on pull request ocaml/ocaml#147
@yminsky

I would argue that the compat module should be a bare minimum synchronization point. There are already several natural places for people to develop…

yminsky commented on pull request ocaml/ocaml#147
@yminsky

That's precisely what I was thinking, and I agree it's better, for the reasons you said. I'd argue against putting any combinators in it for now. I…

yminsky commented on pull request ocaml/ocaml#147
@yminsky

Let's see if I understand what you're saying. With approach 2, a compatibility module would be required for code that wants to be compatible that r…

yminsky commented on pull request ocaml/ocaml#147
@yminsky

It's a fair point. Indeed, I don't have a great idea about how to get both compatibility and having the type be implicitly available everywhere, in…

yminsky commented on pull request ocaml/ocaml#147
@yminsky

What I like about this is that it's a small step in the direction of agreeing on the type, and avoids more controversial questions of library desig…

yminsky commented on pull request ocaml/ocaml#147
@yminsky

In my mind, result is such a close parallel to option, that it strikes me as a truly natural fit with stdlib, and I think it makes sense there. I a…

yminsky commented on issue dbuenzli/result#1
@yminsky

There is now. ocaml/ocaml#147

yminsky opened pull request ocaml/ocaml#147
@yminsky
added result type
1 commit with 7 additions and 0 deletions
@yminsky trunk is now dd90f1b
@yminsky
  • @yminsky 14fe679
    Added result type, intended to ease interoperation for various 3rd pa…
yminsky commented on issue janestreet/core#55
@yminsky

Would you mind providing a command-line invocation that demonstrates the problem? Thanks.

yminsky commented on issue janestreet/core#55
@yminsky

Could you please be more precise? pa_pipebang is a dependency of Core in the sense that Core uses pa_pipebang. On IRC, you were claiming something …

yminsky commented on issue janestreet/core#54
@yminsky

The of_string functions are all like this, and have been for a long time. We decided that it wasn't worth the large amount of churn to fix, but it …

@yminsky
@yminsky
  • @yminsky c832c52
    trying to get lint to like me
yminsky opened pull request ocaml/opam-repository#3616
@yminsky
Update planets package
6 commits with 15 additions and 0 deletions
@yminsky