Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save without index #18

Merged
merged 1 commit into from Oct 20, 2017
Merged

Save without index #18

merged 1 commit into from Oct 20, 2017

Conversation

ynqa
Copy link
Owner

@ynqa ynqa commented Oct 14, 2017

Overview

  • Save without index:
    • before: <word> <index1>:<value1> <index2>:<value2> ...
    • after: <word> <value1> <value2> ...

@ynqa ynqa force-pushed the savewithoutindex branch 2 times, most recently from 24953d7 to 372b587 Compare October 14, 2017 21:02
Repository owner deleted a comment from coveralls Oct 15, 2017
Repository owner deleted a comment from coveralls Oct 15, 2017
Repository owner deleted a comment from coveralls Oct 15, 2017
@chewxy
Copy link
Collaborator

chewxy commented Oct 15, 2017

Is the reason for this smaller binary files?

@ynqa
Copy link
Owner Author

ynqa commented Oct 15, 2017

Simply set the format the same as original word2vec output. I also thought the indexes of word vector are unnecessary info.

Repository owner deleted a comment from coveralls Oct 16, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.185% when pulling c5e520b on savewithoutindex into aa1a18b on master.

Repository owner deleted a comment from coveralls Oct 16, 2017
@chewxy
Copy link
Collaborator

chewxy commented Oct 16, 2017

This way you can just use Gorgonia's serialization methods and dump them

@coveralls
Copy link

coveralls commented Oct 20, 2017

Coverage Status

Coverage remained the same at 49.49% when pulling c9fd2b9 on savewithoutindex into 1d350aa on master.

@ynqa ynqa merged commit b3d9a74 into master Oct 20, 2017
@ynqa ynqa deleted the savewithoutindex branch October 20, 2017 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants