restore sorbet check for dead code #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally disabled in PR #395, but I got some advice on how to re-enable it at [1]. I'm not sure I even want this kind of check really, given how inconsistently they're used across the codebase. Maybe they have value, but only on the public API? Anyway, for now I'm focused on defining types in Sorbet rather than changing behaviour. [1] https://stackoverflow.com/questions/70051079/how-should-i-manage-sorbet-errors-in-a-gem-where-type-info-must-be-in-rbi-files
yob
force-pushed
the
check-dead-code-again
branch
from
7032b54
to
6608364
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally disabled in PR #395, but I got some advice on how to re-enable it on stackoverflow.
I'm not sure I even want this kind of check really, given how inconsistently they're used across the codebase. Maybe they have value, but only on the public API? Anyway, for now I'm focused on defining types in Sorbet rather than changing behaviour.