process_glyph_displacement function error #92

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

nbvehrfr commented Apr 4, 2013

fixed error in process_glyph_displacement function

Owner

yob commented Apr 5, 2013

Thanks for the pull request, but unfortunately this breaks a number of specs (See https://travis-ci.org/yob/pdf-reader/builds/6036569).

It's possible the specs are wrong, but more investigation is required. What was the problem that lead to this patch?

nbvehrfr commented Apr 5, 2013

Hello James,

The attached file from CME market is not correctly parsed.
On page number 3 line begins with "1300 14.90".
The value of Tw and Tc commands must be multiplied with font size. I am not
a guru of pdf spec - this was written in spec from adobe.
After this patch file is displayed correctly.

Timur

On Fri, Apr 5, 2013 at 9:01 AM, James Healy notifications@github.comwrote:

Thanks for the pull request, but unfortunately this breaks a number of
specs (See https://travis-ci.org/yob/pdf-reader/builds/6036569).

It's possible the specs are wrong, but more investigation is required.
What was the problem that lead to this patch?


Reply to this email directly or view it on GitHubhttps://github.com/yob/pdf-reader/pull/92#issuecomment-15954263
.

Contributor

nmadura commented Apr 26, 2013

I suspect that the pull request I just submitted will address this issue.

Specifically commit 36a62b2 that is contained within that pull request

Owner

yob commented Jan 3, 2017

I know this issue hasn't been resolved, but given it's age and lack of tests I'm not sure how to get it across the line. I'll close it for now, but please feel free to re-open if more data becomes available.

yob closed this Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment