Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove .env from index and create .env-dist #983

Open
1 task done
psyray opened this issue Oct 16, 2023 · 5 comments
Open
1 task done

feat: remove .env from index and create .env-dist #983

psyray opened this issue Oct 16, 2023 · 5 comments

Comments

@psyray
Copy link
Contributor

psyray commented Oct 16, 2023

Is there an existing feature or issue for this?

  • I have searched the existing issues

Expected feature

@yogeshojha You should remove .env from git index, and create a .env template called, for example, .env-dist

Because you've add the .env to .gitignore but as the file is in the git index the ignore does not work.

By adding a file .env-dist, user can rename it to .env, change values and this does not trigger a git change

What do you think of this ?

Alternative solutions

No response

Anything else?

No response

@github-actions
Copy link
Contributor

👋 Hi @psyray,
Issues is only for reporting a bug/feature request. Please read documentation before raising an issue https://rengine.wiki
For very limited support, questions, and discussions, please join reNgine Discord channel: https://discord.gg/azv6fzhNCE
Please include all the requested and relevant information when opening a bug report. Improper reports will be closed without any response.

@AnonymousWP
Copy link
Contributor

I think we can fix this ourselves. If you create a PR, I'll merge it into my fork.

@psyray
Copy link
Contributor Author

psyray commented Nov 21, 2023

What's the right way to remove from index but not delete it for user at git pull ?

@AnonymousWP
Copy link
Contributor

What's the right way to remove from index but not delete it for user at git pull ?

Hmm, not sure actually, never experimented with that before. But you do have a point: you want to pull new changes to the .env file, but only the keys, not the values. Renaming could be an option, but I could also see people getting very confused or not following the steps correctly. Maybe automate this in some way?

@psyray
Copy link
Contributor Author

psyray commented Nov 21, 2023

Yes, more complicated than it looks.
Need some test

@psyray psyray added the testing label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants