Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fireaxe cabinet sprite change #22148

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

ktlwjec0
Copy link
Contributor

@ktlwjec0 ktlwjec0 commented Jun 1, 2024

Document the changes in your pull request

tgstation/tgstation#65199
Uses this but changes it slightly to keep our old cabinet shape. If I use the shape they have then I'll have to resprite the other cabinets as it'll look out of place and I can't be bothered to do that.

Why is this good for the game?

New fire axe sprite was ported over but the old cabinet sprite stayed. So the cabinets show the old fire axe currently.

Testing + Spriting

old and new:
image image

🆑 Ebin-Halcyon, ktlwjec
imageadd: New fire axe cabinet sprite.
/:cl:

@ktlwjec0 ktlwjec0 requested a review from a team as a code owner June 1, 2024 17:13
@Yogbot-13 Yogbot-13 added the Sprites This PR has spriting changes label Jun 1, 2024
@AMyriad
Copy link
Contributor

AMyriad commented Jun 1, 2024

Personally not a fan. Smaller sprite with more textures crammed in means it's harder to understand what it is at a glance. And I'm skeptical about us using 3/4ths perspective on wallmounts.

@Moltijoe Moltijoe merged commit b715236 into yogstation13:master Jun 6, 2024
14 checks passed
Yogbot-13 added a commit that referenced this pull request Jun 6, 2024
@AMyriad
Copy link
Contributor

AMyriad commented Jun 6, 2024

it'd appear I've been overruled

@ktlwjec0 ktlwjec0 deleted the cabinet branch July 11, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites This PR has spriting changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants