Skip to content

Test README.md with midje-readme #47

Merged
merged 1 commit into from Jul 24, 2014

2 participants

@boxed
boxed commented Jul 24, 2014

I actually found a single bug in the README.md, namely an extraneous end paren.

A little annoying thing I had to do to make it work was to add documentation for unsetting the resource path so that the tests below it work again :P

@yogthos
Owner
yogthos commented Jul 24, 2014

Great thanks, this is pretty handy :)

@yogthos yogthos merged commit 53678ce into yogthos:master Jul 24, 2014

1 check failed

Details continuous-integration/travis-ci The Travis CI build failed
@yogthos
Owner
yogthos commented Jul 24, 2014

it would be good to show what parts of the README file fails, for example I'm seeing this when testing and it's not obvious what trips the test up:

Exception in thread "main" clojure.lang.LispReader$ReaderException: java.lang.RuntimeException: No reader function for tag Filters, compiling:(readme.clj:221:3)
@boxed
boxed commented Jul 24, 2014

Well crap I realized I fucked up the version of midje-readme in this pull request. Should be 1.0.1. My local system had some non-released stuff in .m2.

@yogthos
Owner
yogthos commented Jul 24, 2014

ok great I just bumped up the version and tests pass

@boxed
boxed commented Jul 24, 2014

Phew. Thanks :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.