Yohan Boniface yohanboniface

Organizations

@liberation
@yohanboniface
@yohanboniface
nombres dans les libellés de voies: 8 rue mil huit cent quatorze toulouse
yohanboniface commented on issue etalab/addok#59
@yohanboniface

Bizarre, y a deux documents pour la même rue on dirait (deux ids différents): > 43 Rue des 36 Ponts TOULOUSE Rue des 36 Ponts Toulouse (31555_XXXX_…

@yohanboniface
Pondération des communes?
@yohanboniface
31555_XXXX_d4baea
@yohanboniface

You should import version from init.py instead

@yohanboniface

Add a message to the assert ?

yohanboniface commented on pull request yohanboniface/OSMTouch#1
@yohanboniface

Exactly :)

yohanboniface commented on pull request yohanboniface/OSMTouch#1
@yohanboniface

Anyway, very good move! I'm looking forward to merge this :)

yohanboniface commented on pull request yohanboniface/OSMTouch#1
@yohanboniface

What about something like "Enter start place or keep empty to use your current location"?

yohanboniface commented on pull request yohanboniface/OSMTouch#1
@yohanboniface

Also, just like when looking for points of interest, I think that routing should push a new page on the stack, so we can go back and remove the rou…

yohanboniface commented on pull request yohanboniface/OSMTouch#1
@yohanboniface

What about using Grapphopper or MapQuest, as in osm.org, for those?

yohanboniface commented on pull request yohanboniface/OSMTouch#1
@yohanboniface

We need to extract this Model in a separate module, to make this a bit DRYer :)

yohanboniface commented on pull request yohanboniface/OSMTouch#1
@yohanboniface

I'd replace the search string by the accepted result to show a confirmation to the user his choice has been selected.

yohanboniface commented on pull request yohanboniface/OSMTouch#1
@yohanboniface

CamelCase to be consistent: fromLon, 'toLon`, etc. :)

yohanboniface commented on pull request yohanboniface/OSMTouch#1
@yohanboniface

I think it's better to keep "where am I" action before, because I feel it's one of the actions you want to access in one click only.

yohanboniface commented on pull request yohanboniface/OSMTouch#1
@yohanboniface

Ah OK, I need to first hit "Enter" on both fields. ;) That's not very intuitive, but may be reworked on bit later. I wonder if we are no hitting th…

yohanboniface commented on pull request yohanboniface/OSMTouch#1
@yohanboniface

Doesn't seem to be working on my laptop (when I click on "by car" I end up on Null island), have you tried on yours or only on the phone directly? …

yohanboniface commented on issue kosmtik/kosmtik#57
@yohanboniface

Well the production servers are using mapnik 2.2 so if you're using 2.3 or 3.x then that might explain the differences? Yes, that's certainly the…

yohanboniface commented on issue kosmtik/kosmtik#57
@yohanboniface

@tomhughes @pnorman Can you maybe provide us the Mapnik XML from production server (cleaned from its passwords if any of course), so we can compare…

yohanboniface commented on pull request ideas-box/ideasbox-scripts#10
@yohanboniface

thanks :)

@yohanboniface
@yohanboniface
Update install.sh
1 commit with 1 addition and 1 deletion
yohanboniface commented on issue Leaflet/Leaflet#3408
@yohanboniface

I would remove !a || from the check given that an undefined a is already covered by LatLngBounds constructor it seems. And consistent signature and…

yohanboniface commented on issue Leaflet/Leaflet#3408
@yohanboniface

Sounds like the initial question was about the different signature of new L.LatLngBounds (which accept no arguments and returns an empty bounds) and

@yohanboniface
  • @yohanboniface ea13a24
    Use PapaParse and display a preview of the loaded CSV (fix #1)
@yohanboniface
  • @yohanboniface de12fc9
    Fix js error when reverse has failed
yohanboniface commented on pull request yohanboniface/OSMTouch#1
@yohanboniface

Sounds Interesting! I'll have a look tonight :)

@yohanboniface
CSV import: try to guess encoding
@yohanboniface
Add a link to csvlint in case of error