Updated checkstyle library and embrace PER 2.0 (#159)

Author: yann-eugone

src/ContainerParameterAccessor.php

@@ -28,7 +28,7 @@ public function get(JobExecution $execution): mixed
         } catch (InvalidArgumentException $exception) {
             throw new CannotAccessParameterException(
                 \sprintf('Cannot access "%s" parameter from container parameters', $this->name),
-                $exception
+                $exception,
             );
         }
     }

src/DependencyInjection/YokaiBatchExtension.php

@@ -88,7 +88,7 @@ private function getLoader(ContainerBuilder $container): LoaderInterface
             [
                 new DependencyInjectionLoader\XmlFileLoader($container, $locator),
                 new DependencyInjectionLoader\DirectoryLoader($container, $locator),
-            ]
+            ],
         );
 
         return new ConfigLoader\DelegatingLoader($resolver);
@@ -111,7 +111,7 @@ private function configureStorage(ContainerBuilder $container, array $config): v
                             'connection' => $config['dbal']['connection'],
                             'table' => $config['dbal']['table'],
                         ],
-                    ]
+                    ],
                 )
             ;
 

src/UserInterface/Controller/JobController.php

@@ -31,7 +31,7 @@ final class JobController
 
     public function __construct(
         private QueryableJobExecutionStorageInterface $jobExecutionStorage,
-        private ?FormFactoryInterface $formFactory,
+        private null|FormFactoryInterface $formFactory,
         private JobSecurity $security,
         private Environment $twig,
         private TemplatingInterface $templating,
@@ -60,7 +60,7 @@ public function list(Request $request): Response
                 [
                     'method' => Request::METHOD_GET,
                     'csrf_protection' => false,
-                ]
+                ],
             );
             $filter->handleRequest($request);
 
@@ -136,7 +136,7 @@ public function list(Request $request): Response
     /**
      * View {@see JobExecution} details in a Twig template.
      */
-    public function view(string $job, string $id, ?string $path = null): Response
+    public function view(string $job, string $id, null|string $path = null): Response
     {
         try {
             $execution = $this->jobExecutionStorage->retrieve($job, $id);
@@ -192,7 +192,7 @@ public function logs(string $job, string $id): Response
         $response = new Response((string)$execution->getLogs());
         $response->headers->set(
             'Content-Disposition',
-            $response->headers->makeDisposition(ResponseHeaderBag::DISPOSITION_ATTACHMENT, $filename)
+            $response->headers->makeDisposition(ResponseHeaderBag::DISPOSITION_ATTACHMENT, $filename),
         );
         $response->headers->set('Content-Type', 'application/log');
 

src/UserInterface/JobSecurity.php

@@ -15,7 +15,7 @@
 final class JobSecurity
 {
     public function __construct(
-        private ?AuthorizationCheckerInterface $authorizationChecker,
+        private null|AuthorizationCheckerInterface $authorizationChecker,
         private string $listAttribute,
         private string $viewAttribute,
         private string $tracesAttribute,

tests/DependencyInjection/CompilerPass/ConfigureLauncherPassTest.php

@@ -26,7 +26,7 @@ public function testNominal(): void
     public function testMissingService(): void
     {
         $this->expectExceptionObject(
-            new LogicException('Job launcher service "app.yokai_batch_job_launcher" does not exists.')
+            new LogicException('Job launcher service "app.yokai_batch_job_launcher" does not exists.'),
         );
         $this->process(function (ContainerBuilder $container) {
             $container->setAlias(JobLauncherInterface::class, 'app.yokai_batch_job_launcher');

tests/DependencyInjection/CompilerPass/ConfigureTemplatingPassTest.php

@@ -26,7 +26,7 @@ public function testNominal(): void
     public function testMissingService(): void
     {
         $this->expectExceptionObject(
-            new LogicException('UI templating service "app.yokai_batch_templating" does not exists.')
+            new LogicException('UI templating service "app.yokai_batch_templating" does not exists.'),
         );
         $this->process(function (ContainerBuilder $container) {
             $container->setAlias(TemplatingInterface::class, 'app.yokai_batch_templating');

tests/DependencyInjection/YokaiBatchExtensionTest.php

@@ -371,13 +371,13 @@ public function errors(): \Generator
         yield 'Per job parameters value must be an array' => [
             ['parameters' => ['per_job' => ['job.foo' => 'string']]],
             new InvalidConfigurationException(
-                'Invalid configuration for path "yokai_batch.parameters.per_job.job.foo": Should be an array<string, mixed>.'
+                'Invalid configuration for path "yokai_batch.parameters.per_job.job.foo": Should be an array<string, mixed>.',
             ),
         ];
         yield 'Per job parameters value must be a string indexed array' => [
             ['parameters' => ['per_job' => ['job.foo' => [1, 2, 3]]]],
             new InvalidConfigurationException(
-                'Invalid configuration for path "yokai_batch.parameters.per_job.job.foo": Should be an array<string, mixed>.'
+                'Invalid configuration for path "yokai_batch.parameters.per_job.job.foo": Should be an array<string, mixed>.',
             ),
         ];
     }

tests/UserInterface/Controller/JobControllerTest.php

@@ -72,7 +72,7 @@ protected function setUp(): void
     public function testList(
         \Closure $fixtures,
         Request $request,
-        ?FormFactoryInterface $formFactory,
+        null|FormFactoryInterface $formFactory,
         JobSecurity $security,
         TemplatingInterface $templating,
         int $expectedStatus,
@@ -197,7 +197,7 @@ public function testView(
         \Closure $fixtures,
         string $job,
         string $id,
-        ?string $path,
+        null|string $path,
         JobSecurity $security,
         TemplatingInterface $templating,
         int $expectedStatus,
@@ -235,7 +235,7 @@ public static function view(): \Generator
                         new Summary(['count' => 156]),
                     );
                     $exportExecution->addWarning(
-                        new Warning('Skipped suspicious record', [], ['suspicious_record' => 2])
+                        new Warning('Skipped suspicious record', [], ['suspicious_record' => 2]),
                     );
                     $exportExecution->addFailure(new Failure('RuntimeException', 'Missing record #2', 0));
                     $exportExecution->setStartTime(new \DateTimeImmutable('2021-01-01 10:00'));
@@ -447,7 +447,7 @@ private static function templatings(): \Generator
      */
     private function response(
         \Closure $closure,
-        ?FormFactoryInterface $formFactory,
+        null|FormFactoryInterface $formFactory,
         JobSecurity $security,
         TemplatingInterface $templating,
     ): Response {
@@ -461,7 +461,7 @@ private function response(
     }
 
     private function controller(
-        ?FormFactoryInterface $formFactory,
+        null|FormFactoryInterface $formFactory,
         JobSecurity $security,
         TemplatingInterface $templating,
     ): JobController {
@@ -519,7 +519,7 @@ private static function fixtures(int $count, array $attributes = []): void
                     ])),
                     'startTime' => $start = (new \DateTimeImmutable())->setTimestamp(\random_int(0, \time() - 10)),
                     'endTime' => (new \DateTimeImmutable())->setTimestamp(
-                        \random_int($start->getTimestamp(), \time() - 10)
+                        \random_int($start->getTimestamp(), \time() - 10),
                     ),
                 ],
                 $attributes,
@@ -545,7 +545,7 @@ private static function assertSelectorTextContains(Crawler $crawler, string $sel
     {
         self::assertThat($crawler, LogicalAnd::fromConstraints(
             new DomCrawlerConstraint\CrawlerSelectorExists($selector),
-            new DomCrawlerConstraint\CrawlerSelectorTextContains($selector, $text)
+            new DomCrawlerConstraint\CrawlerSelectorTextContains($selector, $text),
         ));
     }