Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Package in various target #224

Closed
wants to merge 6 commits into from
Closed

Conversation

mackoj
Copy link
Contributor

@mackoj mackoj commented Mar 9, 2020

This will give more control on which part of generated code you want to use:

  • only Models (no need for Alamofire)
  • Models + Requests (no need for Alamofire)
  • Models + Request + Client (required Alamofire)

All of this is usable with or without dynamic library(it will now work with my dependencies that are used in Xcodegen and are imported in multiples frameworks)

This should change nothing at all to most people except the removal of timeline.

This should simplify the migration out of Alamofire because now there is only one part of the code to focus on to remove it.

This should simplify refactoring of a part of the template if needed.

Issue

  • This force me to remove Timeline feature of Alamofire.

@mackoj
Copy link
Contributor Author

mackoj commented Mar 9, 2020

I would love to have some comment from @yonaskolb about this.

@mackoj mackoj marked this pull request as ready for review March 9, 2020 14:54
@mackoj mackoj changed the title Split Package in various target in order to simplify not using Alamofire Split Package in various target in order to simplify refactoring Mar 9, 2020
@mackoj mackoj changed the title Split Package in various target in order to simplify refactoring Split Package in various target Mar 9, 2020
@mackoj
Copy link
Contributor Author

mackoj commented Mar 9, 2020

This not ready for review yet I have to add missing helper to build a URLRequest from an APIRequest.

@mackoj mackoj closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant