Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print version with -v too #174

Merged
merged 1 commit into from Dec 1, 2017
Merged

Conversation

kastiglione
Copy link
Collaborator

@kastiglione kastiglione commented Nov 27, 2017

Would it be reasonable to support -v in addition to --version?

@yonaskolb
Copy link
Owner

It would indeed be reasonable @kastiglione :)
It might clash with a future --verbose flag though. And if Commander already makes the decision to restrict to --version perhaps that's a good default. What do you think? Are you used to using -v?

@kastiglione
Copy link
Collaborator Author

Good points. Hopefully Commander wouldn't force that, but I see the concern there.

We have a version of XcodeGen that I want to upgrade to use the latest upstream release. Our XcodeGen has a -v flag (but not --version), and that flag is used by other tools to tell whether the local copy is out of date and needs an update. I could work around the -v/--version discrepancy in other ways, but if XcodeGen officially supports -v then that makes it easier.

Personally, I never like it when I run -v on some command and find out it does nothing and then try --version and see that it works. I can see if -v had some other meaning, but having no meaning seems unfortunate. For verbose, that could be -V, and since CAPS usually means loud, that could be suitable for verbose. I could try to add -v to Commander, as another approach.

Do you think XcodeGen is going to have a verbose mode? It already seems verbose/detailed as a default.

@yonaskolb
Copy link
Owner

Some good counter points :)

@yonaskolb yonaskolb merged commit 3fd2eff into yonaskolb:master Dec 1, 2017
@kastiglione
Copy link
Collaborator Author

Thanks!

@kastiglione kastiglione deleted the dash-v branch December 1, 2017 22:12
@kastiglione
Copy link
Collaborator Author

What do you think, should I open a pull request in Commander to see if they'll make -v an official alias for --version?

@yonaskolb
Copy link
Owner

Yeah, I think it's worth a PR. It should probably be done in a way in that if anyone manually adds a -v flag it will use that instead, and only print version as a fallback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants