Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should register command be removed in favor of setup? #16

Open
pelcasandra opened this issue Jan 19, 2019 · 3 comments
Open

Should register command be removed in favor of setup? #16

pelcasandra opened this issue Jan 19, 2019 · 3 comments
Assignees
Projects

Comments

@pelcasandra
Copy link
Collaborator

It looks to me the yorokobi register now is deprecated in favor of the yorokobi setup instead.

Should it be removed then?

@pelcasandra pelcasandra added this to the Release 1 milestone Jan 19, 2019
@intjelic
Copy link
Contributor

I find it clean to keep it next its counterpart command unregister.

After installation of the agent, the user is required to do two things: registering the agent, and configuring the first database. See setup as the command to do the minimal initialization required for the agent to start doing something useful.

@intjelic
Copy link
Contributor

It's also easier to introduce the agent with only one command. And let more experimented users dig into the documentation if they need more.

@pelcasandra
Copy link
Collaborator Author

It is still unclear to me what is the purpose of yorokobi register command as yorokobi setup already is registering the agent. When I run it nothing seems to happen.

(python-env) martin@martin-VirtualBox:~/agent$ yorokobi register
(python-env) martin@martin-VirtualBox:~/agent$ 

I'm unconvinced about having a command that does something that already does yorokobi setup.

@pelcasandra pelcasandra added this to To do in v0.1.3 Jan 25, 2019
@pelcasandra pelcasandra removed this from the Release 1 milestone Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
v0.1.3
  
To do
Development

No branches or pull requests

2 participants