Generate test/ctags_stub.py with automake #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even since 4632629 (Detect python executable path for tests too.) the test suite failed to pass on systems where python3 is the default executable for "python". This happened because test/ctags_stub.py would still use the default of /usr/bin/python3, since environment variable updates were only present during the config/make stages. This changes test/ctags_stub.py to have an autogenerated shebang (#!) line using automake. It resolves build issues by forcing use of the python version chosen during configure regardless of the python environment variable chosen at runtime.
yoshizow
added a commit
that referenced
this pull request
Sep 1, 2014
Generate test/ctags_stub.py with automake
Owner
|
Thank you for your kind support. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even since 4632629 (Detect python executable path for tests too.) the
test suite failed to pass on systems where python3 is the default
executable for "python". This happened because test/ctags_stub.py would
still use the default of /usr/bin/python3, since environment variable
updates were only present during the config/make stages.
This changes test/ctags_stub.py to have an autogenerated shebang (#!)
line using automake. It resolves build issues by forcing use of the
python version chosen during configure regardless of the python
environment variable chosen at runtime.
Let me know if there's anything else you'd like to see with these changes.
I'm very appreciative of your work on #2 to help create clean builds across
systems. 👍