New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate test/ctags_stub.py with automake #3

Merged
merged 1 commit into from Sep 1, 2014

Conversation

Projects
None yet
2 participants
@nathantypanski
Contributor

nathantypanski commented Sep 1, 2014

Even since 4632629 (Detect python executable path for tests too.) the
test suite failed to pass on systems where python3 is the default
executable for "python". This happened because test/ctags_stub.py would
still use the default of /usr/bin/python3, since environment variable
updates were only present during the config/make stages.

This changes test/ctags_stub.py to have an autogenerated shebang (#!)
line using automake. It resolves build issues by forcing use of the
python version chosen during configure regardless of the python
environment variable chosen at runtime.


Let me know if there's anything else you'd like to see with these changes.
I'm very appreciative of your work on #2 to help create clean builds across
systems. 馃憤

Generate test/ctags_stub.py with automake
Even since 4632629 (Detect python executable path for tests too.) the
test suite failed to pass on systems where python3 is the default
executable for "python". This happened because test/ctags_stub.py would
still use the default of /usr/bin/python3, since environment variable
updates were only present during the config/make stages.

This changes test/ctags_stub.py to have an autogenerated shebang (#!)
line using automake. It resolves build issues by forcing use of the
python version chosen during configure regardless of the python
environment variable chosen at runtime.

yoshizow added a commit that referenced this pull request Sep 1, 2014

Merge pull request #3 from nathantypanski/master
Generate test/ctags_stub.py with automake

@yoshizow yoshizow merged commit a60aa3d into yoshizow:master Sep 1, 2014

@yoshizow

This comment has been minimized.

Owner

yoshizow commented Sep 1, 2014

Thank you for your kind support. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment