Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Sep 17, 2014
  1. @antirez

    Cluster: claim ping_sent time even if we can't connect.

    antirez authored
    This fixes a potential bug that was never observed in practice since
    what happens is that the asynchronous connect returns ok (to fail later,
    calling the handler) every time, so a ping is queued, and sent_ping
    happens to always be populated.
    
    Howver technically connect(2) with a non blocking socket may return an
    error synchronously, so before this fix the code was not correct.
  2. @antirez
Commits on Sep 16, 2014
  1. @antirez

    Better truncated AOF loading tests.

    antirez authored
    Now there are tests to write more data after loading a truncated AOF,
    testing that the loaded data is correct, appending more, and testing
    again.
  2. @antirez

    Seek at the end of AOF after truncate call.

    antirez authored
    It is not clear if files open in append only mode will automatically fix
    their offset after a truncate(2) operation. This commit makes sure that
    we reposition the AOF file descriptor offset at the end of the file
    after a truncated AOF is loaded and trimmed to the last valid command.
  3. @antirez

    On AOF end of file, truncate the AOF to last valid command.

    antirez authored
    Recently we introduced the ability to load truncated AOFs, but
    unfortuantely the support was broken since the server, after loading the
    truncated AOF, continues appending to the file that is corrupted at the
    end. The problem is fixed only in the next AOF rewrite.
    
    This commit fixes the issue by truncating the AOF to the last valid
    opcode, and aborting if it is not possible to truncate the file
    correctly.
  4. @antirez

    Don't propagate SAVE.

    antirez authored
    This is a general fix (check that dirty delta is positive) but actually
    should have as the only effect fixing the SAVE propagation to
    AOF and slaves.
Commits on Sep 15, 2014
  1. @antirez
  2. @antirez
Commits on Sep 11, 2014
  1. @antirez
  2. @antirez

    Sentinel: fix computation of total number of votes.

    antirez authored
    The code to check the number of voters was never updated to follow the new
    Sentinel specification, so the number of voters was computed using only
    the set of Sentinels that provided a vote.
    
    This means that there is a changing majority on partitions, even if
    usually the issue is not triggered because of the configured quorum
    check (what was broken was the other implicit check that requires anyway
    half of the known sentinels to agree in order to start a failover).
Commits on Sep 10, 2014
  1. @antirez

    luaRedisGenericCommand() cached argv handling simplified.

    antirez authored
    As discussed in issue #1945.
  2. @antirez

    Merge pull request #1993 from xiaost/limit-scan-iter-count

    antirez authored
    Limit the *SCAN command `dictScan` iterations
Commits on Sep 9, 2014
  1. @xiaost

    Limit the *SCAN command `dictScan` iterations

    xiaost authored
    *SCAN will cause redis server to hang for seconds
    after millions of keys was deleted by SCAN/DEL pairs
Commits on Sep 8, 2014
  1. @antirez
  2. @antirez

    AOF tests fixed turning aof-load-truncated to no.

    antirez authored
    When aof-load-truncated option was introduced, with a default of "yes",
    the past behavior of the server to abort with trunncated AOF changed, so
    we need to explicitly configure the tests to abort with truncated AOF
    by setting the option to no.
  3. @antirez
  4. @antirez

    Correct cleanup when aborting AOF loading.

    antirez authored
    Because of the new ability to start with a truncated AOF, we need
    to correctly release all the memory on EOF error. Otherwise there is a
    small leak, that is not really a problem, but causes a false positive in
    the tests that detect memory leaks.
  5. @antirez
  6. @antirez
  7. @antirez
Commits on Sep 4, 2014
  1. @antirez
  2. @antirez
  3. @antirez
  4. @antirez

    Sentinel: announce ip/port changes + rewrite.

    antirez authored
    The original implementation was modified in order to allow to
    selectively announce a different IP or port, and to rewrite the two
    options in the config file after a rewrite.
  5. @dkong @antirez

    sentinel: Decouple bind address from address sent to other sentinels

    dkong authored antirez committed
    There are instances such as EC2 where the bind address is private
    (behind a NAT) and cannot be accessible from WAN.
    
    https://groups.google.com/d/msg/redis-db/PVVvjO4nMd0/P3oWC036v3cJ
Commits on Sep 3, 2014
  1. @antirez

    Merge pull request #1982 from mattsta/fix-getrange-32bit

    antirez authored
    Increase size of range request in getrange
Commits on Sep 2, 2014
  1. @mattsta

    Return empty string if GETRANGE of empty string

    mattsta authored
    Previously, GETRANGE of a key containing nothing ("")
    would allocate a large (size_t)-1 return value causing
    crashes on 32bit builds when it tried to allocate the
    4 GB return string.
  2. @mattsta

    Increase size of range request in getrange

    mattsta authored
    32 bit builds don't have a big enough long to capture
    the same range as a 64 bit build.  If we use "long long"
    we get proper size limits everywhere.
    
    Also updates size of unsigned comparison to fit new size of `end`.
    
    Fixes #1981
Commits on Sep 1, 2014
  1. @mattsta @antirez

    Sentinel: Abort Hello quicker if not connected

    mattsta authored antirez committed
    We can save a little work by aborting when we enter the function
    if we're disconnected.
  2. @paddybyers @antirez

    Add regression test for issue #1939

    paddybyers authored antirez committed
  3. @paddybyers @antirez
Commits on Aug 26, 2014
  1. @antirez

    Fix dictRehash assert casting type.

    antirez authored
    Also related to #1929.
  2. @antirez

    Cast to right type in dictNext().

    antirez authored
    This closes issue #1929, the other part was fixed in the context of issue
  3. @antirez

    Use long for rehash and iterator index in dict.h.

    antirez authored
    This allows to support datasets with more than 2 billion of keys
    (possible in very large memory instances, this bug was actually
    reported).
    
    Closes issue #1814.
  4. @antirez
Something went wrong with that request. Please try again.