Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update library version #79

Closed
wants to merge 5 commits into from

Conversation

@cylim
Copy link
Member

commented Aug 21, 2019

close #78

Generally, most benchmark is getting worse due to my laptop is not as powerful as the one used to perform the test previously

@coveralls

This comment has been minimized.

Copy link

commented Aug 21, 2019

Pull Request Test Coverage Report for Build 197

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 195: 0.0%
Covered Lines: 43
Relevant Lines: 43

💛 - Coveralls
@stevemao

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Could you also remove

Note that the provided examples of date-fns are for v2 which is in pre-release right now. See v1 docs for the current release.

@cht8687 cht8687 self-requested a review Aug 22, 2019

@cht8687

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Good work!

@stevemao

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

@cylim Why is screenshot.png deleted?

@stevemao stevemao requested review from stevemao and ddvkid Aug 22, 2019

@cylim

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

@cylim Why is screenshot.png deleted?

@stevemao replaced, not deleted. The reason is upgrading libraries will affect the sizes. I can change it back if wanted to keep the original.

@ddvkid
ddvkid approved these changes Aug 22, 2019
Merge pull request #79 from cylim/master
update library version
@stevemao

This comment has been minimized.

Copy link
Member

commented Aug 22, 2019

Sorry, I thought it was deleted. Thanks for the PR

@cylim cylim closed this Aug 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.