Skip to content

chore(ci): add cgroup v1 compatibility for tests on ubuntu-24.04 - #3102

Merged
utam0k merged 1 commit into
youki-dev:mainfrom
sou1118:feature/ci-cgroup-v1-support
Mar 11, 2025
Merged

chore(ci): add cgroup v1 compatibility for tests on ubuntu-24.04#3102
utam0k merged 1 commit into
youki-dev:mainfrom
sou1118:feature/ci-cgroup-v1-support

Conversation

@sou1118

@sou1118 sou1118 commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

Description

This PR adds support for testing with cgroups v1 on Ubuntu 24.04 by integrating Lima with AlmaLinux 8. AlmaLinux 8 provides an environment with cgroups v1 which allows us to maintain compatibility testing while upgrading the CI infrastructure to Ubuntu 24.04.

The implementation:

  • Uses Lima to create a virtual machine with AlmaLinux 8 when running cgroups v1 tests
  • Configures Docker in the guest VM and forwards the Docker socket to the host
  • Maintains matrix testing for both cgroups v1 and v2 environments
  • Keeps the workflow streamlined with conditional steps based on the cgroup version

This is a follow-up to PR #3097 which upgraded the GitHub Actions workflows to Ubuntu 24.04.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test updates
  • CI/CD related changes
  • Other (please describe):

Testing

  • Added new unit tests
  • Added new integration tests
  • Ran existing test suite in both cgroups v1 (Lima/AlmaLinux) and cgroups v2 (native) environments
  • Tested manually by running the workflow locally with Lima

Related Issues

Fixes #3095

Additional Context

The approach was inspired by the containerd/nerdctl implementation (4d76aa96b44df51e975171216d54879794b50605) which successfully uses Lima to provide cgroups v1 compatibility testing on modern Ubuntu versions.

@sou1118
sou1118 force-pushed the feature/ci-cgroup-v1-support branch from 79f98cd to d115a25 Compare March 8, 2025 02:48
@sou1118 sou1118 changed the title chore(ci): add cgroups v1 compatibility for tests on ubuntu-24.04 chore(ci): add cgroup v1 compatibility for tests on ubuntu-24.04 Mar 8, 2025
@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 9, 2025
@utam0k

utam0k commented Mar 9, 2025

Copy link
Copy Markdown
Member

The approach was inspired by the containerd/nerdctl implementation (4d76aa96b44df51e975171216d54879794b50605) which successfully uses Lima to provide cgroups v1 compatibility testing on modern Ubuntu versions.

💯

Comment thread .github/workflows/e2e.yaml Outdated
- uses: actions/checkout@v4
with:
fetch-depth: 1
# Common step for both versions

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this comment needs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it!

…ux 8)

Signed-off-by: sou1118 <hello@kattyan.dev>
@sou1118
sou1118 force-pushed the feature/ci-cgroup-v1-support branch from d115a25 to f2063ac Compare March 9, 2025 12:29
@sou1118
sou1118 requested a review from utam0k March 9, 2025 12:35

@utam0k utam0k left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@utam0k
utam0k merged commit b445a1c into youki-dev:main Mar 11, 2025
@github-actions github-actions Bot mentioned this pull request Mar 11, 2025
@sou1118
sou1118 deleted the feature/ci-cgroup-v1-support branch March 11, 2025 14:14
@github-actions github-actions Bot mentioned this pull request Mar 18, 2025
github-actions Bot pushed a commit that referenced this pull request Mar 18, 2025
…ux 8) (#3102)

Signed-off-by: sou1118 <hello@kattyan.dev>
github-actions Bot pushed a commit that referenced this pull request Mar 18, 2025
…ux 8) (#3102)

Signed-off-by: sou1118 <hello@kattyan.dev>
@github-actions github-actions Bot mentioned this pull request Mar 20, 2025
sat0ken pushed a commit to sat0ken/youki that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Upgrade GitHub Actions workflows from Ubuntu 20.04 to 24.04

2 participants