Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to listen to didSelectRowAt event for NonExpandableCell #1

Closed
kohdesmond opened this issue Mar 20, 2017 · 9 comments
Closed

How to listen to didSelectRowAt event for NonExpandableCell #1

kohdesmond opened this issue Mar 20, 2017 · 9 comments
Assignees

Comments

@kohdesmond
Copy link

HI YN, good git!

just wondering how do you listen to didSelectRowAt event for NonExpandableCell ?

cheers

des

@younatics
Copy link
Owner

Hello @kohdesmond,
I will make that function today.
I will close this issue if I done it.

Cheers,
Younatics

@younatics
Copy link
Owner

I made delegate for you 👍
see v0.3.0

@younatics younatics self-assigned this Mar 20, 2017
@kohdesmond
Copy link
Author

Sweet thanks! it works!

@kohdesmond
Copy link
Author

@younatics the didSelectRow was not called when expanded cell closed

@younatics
Copy link
Owner

I will check it again

@younatics younatics reopened this Mar 21, 2017
@younatics younatics added the bug label Mar 21, 2017
@kohdesmond
Copy link
Author

kohdesmond commented Mar 21, 2017

public func tableView(_ tableView: UITableView, didDeselectRowAt indexPath: IndexPath) {

was called when closing the expanding cell, but delegate was not called

hence func tableView(_ tableView: YNTableView, didSelectRowAt indexPath: IndexPath, isExpandedCell: Bool)

only works when opening not closed.

@younatics younatics removed the bug label Mar 21, 2017
@younatics
Copy link
Owner

younatics commented Mar 21, 2017

I will make didDeselectRowAt delegate too! 👍
I will tell you if it is finished

@kohdesmond
Copy link
Author

+1

@younatics
Copy link
Owner

I made didDeselectRowAt delegate.
see v0.5.0
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants