Security Fix for Directory Traversal - huntr.dev #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://huntr.dev/users/Mik317 has fixed the Directory Traversal vulnerability🔨 . Mik317 has been awarded $25 for fixing the vulnerability through the huntr bug bounty program 💵 . Think you could fix a vulnerability like this?
Get involved at https://huntr.dev/
Q | A
Version Affected | ALL
Bug Fix | YES
Original Pull Request | 418sec#1
Vulnerability README | https://github.com/418sec/huntr/blob/master/bounties/npm/web-node-server/1/README.md
User Comments:
Bounty URL: https://www.huntr.dev/bounties/1-npm-web-node-server
The
nodeserverserver was vulnerable againstpath traversalthrough the../technique, leading toinformation exposureandfile content disclosure.I implemented a simple
fixwhich makes possible sanitizing any occurrence of../and different vectors, using a regex, in order to check and avoid bypassesOS-basedwhich are really common nowadays.I didn't add other
pagesfor forbidden message, since when a file is sanitized andnot found, by design the server will reply with theindex.htmlfile.test.jswith the following content:node test.jscurl --path-as-is http://localhost:9999/../../../../../../../../../../etc/passwd/etc/passwdis showedSame steps above with fixed version == no😄
/etc/passwdshowedAll OK😄