since a data structure might contain nil, test for emptiness of input ex... #23

Merged
merged 1 commit into from Jan 3, 2013

Conversation

Projects
None yet
2 participants
@bwo

bwo commented Jan 2, 2013

...plicitly.

The parser combinators here can be used on more than just strings, as the readme acknowledges, but if you use it to parse clojure data structures (lists etc.), then, since they might contain nil, if-let [tok (first input)] ...) will occasionally consider the input empty even when it is not.

youngnh added a commit that referenced this pull request Jan 3, 2013

Merge pull request #23 from bwo/fix-token
test for emptiness of input explicitly

@youngnh youngnh merged commit 076c1a5 into youngnh:master Jan 3, 2013

@bwo bwo deleted the bwo:fix-token branch Jan 14, 2013

@bwo

This comment has been minimized.

Show comment Hide comment
@bwo

bwo Jan 14, 2013

If it's not too much trouble can you push this fix to clojars? I have a project that is mostly useless without it.

bwo commented Jan 14, 2013

If it's not too much trouble can you push this fix to clojars? I have a project that is mostly useless without it.

@youngnh

This comment has been minimized.

Show comment Hide comment
@youngnh

youngnh Jan 14, 2013

Owner

pushed as part of 0.0.4

Owner

youngnh commented Jan 14, 2013

pushed as part of 0.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment