New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 1.7 SimpleAdminConfig use import error fix #252

Merged
merged 2 commits into from Apr 27, 2014

Conversation

Projects
None yet
3 participants
@fallenflint
Contributor

fallenflint commented Feb 21, 2014

From Django 1.7 release notes: django.contrib.admin will now automatically perform autodiscovery of admin modules in installed applications. To prevent it, change your INSTALLED_APPS to contain 'django.contrib.admin.apps.SimpleAdminConfig' instead of 'django.contrib.admin'.

So using default admin app causes autocomplete_light.exceptions.AutocompleteNotRegistered (registry is empty) error.
Temporary workaround is to use SimpleAdminConfig, but it seems like current behaviour must be changed from one described in docs: http://django-autocomplete-light.readthedocs.org/en/latest/install.html#call-autocomplete-light-autodiscover-before-admin-autodiscover

@jpic

This comment has been minimized.

Member

jpic commented Feb 22, 2014

Wouldn't that workaround make is just as if we weren't trying to import it all ?

Could you backport changes from 1.7's django.contrib.admin.autodiscover to autocomplete_light.registry.autodiscover ?

Thanks !

@blueyed

This comment has been minimized.

Member

blueyed commented Mar 24, 2014

FWIW, I had no issues with autocomplete-light and Django 1.7 (until now at least ;).

jpic added a commit that referenced this pull request Apr 27, 2014

Merge pull request #252 from fallenflint/v2
Django 1.7 SimpleAdminConfig use import error fix

@jpic jpic merged commit c5d9c70 into yourlabs:v2 Apr 27, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment