yourls_do_action calls yourls_apply_filter with all arguments in an array rather than as a list

[ozh]

This is a COPY of Issue 1203: yourls_do_action calls yourls_apply_filter with all arguments in an array rather than as a list, filed on Google Code before the project was moved on Github.

• Submitted on 2012-10-09T18:20:46.000Z by johnpbl...@gmail.com
• Status: New

Please review the original issue and especially its comments. Comments here on closed issues will be ignored. Thanks.

Original description

yourls_do_action always sends all args to yourls_apply_filter as a single array, but yourls_apply_filter uses them as if they're sent as individual arguments. The fix is to use call_user_func_array to call yourls_apply_filter. Patch attached.

[ozh]

Copying original patch, before Google Code goes missing:

Index: includes/functions-plugins.php
===================================================================
--- includes/functions-plugins.php  (revision 771)
+++ includes/functions-plugins.php  (working copy)
@@ -155,7 +155,7 @@
 }

 function yourls_do_action( $hook, $arg = '' ) {
-   $args = array();
+   $args = array( $hook );
    if ( is_array( $arg ) && 1 == count( $arg ) && isset( $arg[0] ) && is_object( $arg[0] ) ) // array(&$this)
        $args[] =& $arg[0];
    else
@@ -163,7 +163,7 @@
    for ( $a = 2; $a < func_num_args(); $a++ )
        $args[] = func_get_arg( $a );

-   yourls_apply_filter( $hook, $args );
+   call_user_func_array( 'yourls_apply_filter', $args );
 }


@@ -505,4 +505,4 @@
    yourls_html_footer();

    die();
-}
\ No newline at end of file
+}

[ozh]

Copying original patch, before Google Code goes missing:

Index: includes/functions-plugins.php
===================================================================
--- includes/functions-plugins.php  (revision 771)
+++ includes/functions-plugins.php  (working copy)
@@ -155,7 +155,7 @@
 }

 function yourls_do_action( $hook, $arg = '' ) {
-   $args = array();
+   $args = array( $hook );
    if ( is_array( $arg ) && 1 == count( $arg ) && isset( $arg[0] ) && is_object( $arg[0] ) ) // array(&$this)
        $args[] =& $arg[0];
    else
@@ -163,7 +163,7 @@
    for ( $a = 2; $a < func_num_args(); $a++ )
        $args[] = func_get_arg( $a );

-   yourls_apply_filter( $hook, $args );
+   call_user_func_array( 'yourls_apply_filter', $args );
 }


@@ -505,4 +505,4 @@
    yourls_html_footer();

    die();
-}
\ No newline at end of file
+}