From 0b6c0ed44aac279fb9fb4397542a16fbeabf0dc4 Mon Sep 17 00:00:00 2001 From: Yousong Zhou Date: Thu, 8 Aug 2019 06:21:32 +0000 Subject: [PATCH] collectd: remove the patch scaling ping_droprate from 0-1 to 0-100 Upstream project's behaviour of reporting this data source in range 0-1 is used by at least CentOS 7 collectd 5.8.1, very likely the same behaviour is also in widely use by other distributions. The change is important for providing consistent experience across collectd deployments on different environments Ref: https://github.com/collectd/collectd/pull/3244 Signed-off-by: Yousong Zhou --- utils/collectd/Makefile | 2 +- utils/collectd/patches/920-fix-ping-droprate.patch | 11 ----------- 2 files changed, 1 insertion(+), 12 deletions(-) delete mode 100644 utils/collectd/patches/920-fix-ping-droprate.patch diff --git a/utils/collectd/Makefile b/utils/collectd/Makefile index b9d30581212db8..21a2285ddc810f 100644 --- a/utils/collectd/Makefile +++ b/utils/collectd/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=collectd PKG_VERSION:=5.9.0 -PKG_RELEASE:=3 +PKG_RELEASE:=4 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2 PKG_SOURCE_URL:=https://collectd.org/files/ \ diff --git a/utils/collectd/patches/920-fix-ping-droprate.patch b/utils/collectd/patches/920-fix-ping-droprate.patch deleted file mode 100644 index 6b1e9a0d4a3fcc..00000000000000 --- a/utils/collectd/patches/920-fix-ping-droprate.patch +++ /dev/null @@ -1,11 +0,0 @@ ---- a/src/ping.c -+++ b/src/ping.c -@@ -648,7 +648,7 @@ static int ping_read(void) /* {{{ */ - ((double)(pkg_recv * (pkg_recv - 1)))); - - /* Calculate drop rate. */ -- droprate = ((double)(pkg_sent - pkg_recv)) / ((double)pkg_sent); -+ droprate = ((double)(pkg_sent - pkg_recv)) * 100 / ((double)pkg_sent); - - submit(hl->host, "ping", latency_average); - submit(hl->host, "ping_stddev", latency_stddev);