New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new feature] NoticeBar: add close event #2692

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@chenjiahan
Copy link
Member

chenjiahan commented Feb 6, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #2692 into dev will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2692      +/-   ##
==========================================
+ Coverage   89.85%   90.11%   +0.26%     
==========================================
  Files         103      103              
  Lines        1981     1983       +2     
==========================================
+ Hits         1780     1787       +7     
+ Misses        201      196       -5
Impacted Files Coverage Δ
packages/notice-bar/index.js 69.23% <100%> (+23.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa872e...262eff4. Read the comment docs.

@chenjiahan chenjiahan merged commit 9c5e5b8 into youzan:dev Feb 6, 2019

3 checks passed

codecov/patch 100% of diff hit (target 89.85%)
Details
codecov/project 90.11% (+0.26%) compared to 8fa872e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment