New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Dialog: beforeClose not work for click overlay #2707

Merged
merged 3 commits into from Feb 9, 2019

Conversation

Projects
None yet
2 participants
@chenjiahan
Copy link
Member

chenjiahan commented Feb 9, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 9, 2019

Codecov Report

Merging #2707 into dev will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #2707      +/-   ##
==========================================
+ Coverage   90.01%   90.03%   +0.02%     
==========================================
  Files         103      103              
  Lines        2013     2018       +5     
  Branches       19       19              
==========================================
+ Hits         1812     1817       +5     
  Misses        200      200              
  Partials        1        1
Impacted Files Coverage Δ
packages/mixins/popup/manager.js 100% <100%> (ø) ⬆️
packages/dialog/Dialog.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 683e6d5...ab71718. Read the comment docs.

chenjiahan added some commits Feb 9, 2019

fix

@chenjiahan chenjiahan merged commit e64b908 into youzan:dev Feb 9, 2019

3 checks passed

codecov/patch 100% of diff hit (target 90.01%)
Details
codecov/project 90.03% (+0.02%) compared to 683e6d5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment