Make the build reproducible #4220
Conversation
Whilst working on the Reproducible Builds effort [0] I noticed that yt-dlp could not be built reproducibly. This is due to `sort_ies` iterating over a Python set() data structure in a nondeterminstic order. This patch sorts the type objects according to their name. I originally filed this in Debian as bug #1014041 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/1014041
|
I don't think just this change is sufficient to make the builds reproducible |
pukkandan
added
the
docs/meta/cleanup
Oh, any other area you think might not be reproducible...? (This change makes the build reproducible according to my own tests, at least...) |
|
Which build are you testing? The wheel? |
|
Actually I'm building the Debian package which, it seems, calls the Makefile and |
|
That can barely be called a build... It's just a copy of the source code |
|
I have merged this because it is harmless at worst. But in general, I cannot promise that no other inconsistency will be added in future versions |
Sure... but, what were you expecting? I think I might be missing something. :) |
|
yt-dlp can be built in many forms such as |
Authored by: lamby
Whilst working on the Reproducible Builds effort I noticed that yt-dlp could not be built reproducibly.
This is due to
sort_iesiterating over a Pythonset()data structure in a nondeterminstic order. This patch sorts thetypeobjects according to their name.I originally filed this in Debian as bug #1014041.