Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extractor/zoom] Update extraction logic #6741

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

shreyasminocha
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

The zoom extractor broke recently due to upstream changes. This is an attempt to fix that.

Fixes #6677

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

@shreyasminocha
Copy link
Contributor Author

shreyasminocha commented Apr 7, 2023

Downloading simple non-password-protected videos works, but I haven't tested these yet:

  • subtitle extraction
  • password-protected videos
  • downloading the screen share recording

yt_dlp/extractor/zoom.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zoom.py Outdated Show resolved Hide resolved
@pukkandan pukkandan added site-bug Issue with a specific website pending-fixes PR has had changes requested labels Apr 7, 2023
yt_dlp/extractor/zoom.py Outdated Show resolved Hide resolved
yt_dlp/extractor/zoom.py Outdated Show resolved Hide resolved
@pukkandan pukkandan removed the pending-fixes PR has had changes requested label Apr 7, 2023
yt_dlp/extractor/zoom.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zoom.us] Fails with No video formats found!
2 participants