Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to new colorbar behavior in mpl 3.0. fixes #2099 #2101

Merged
merged 3 commits into from Nov 26, 2018

Conversation

Projects
None yet
4 participants
@ngoldbaum
Copy link
Member

commented Nov 26, 2018

Matplotlib 3.0 includes a number of improvements to colorbars, one of which makes a hack in yt's handling of colorbars unnecessary, leading to the weird behavior in #2099. The fix is to guard the hack behind a matplotlib version check.

@cphyc

cphyc approved these changes Nov 26, 2018

@ngoldbaum

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2018

Ugh wish I'd looked closer at the test failures when I updated the tests to use matplotlib 3, would have caught this then. Oh well.... Will push new test answers shortly.

@ngoldbaum ngoldbaum merged commit 3ce43cb into yt-project:master Nov 26, 2018

6 checks passed

codecov/patch 100% of diff hit (target 49.74%)
Details
codecov/project 70.87% (+21.12%) compared to d62029c
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
py2 Build finished.
Details
py3 Build finished.
Details

@ngoldbaum ngoldbaum deleted the ngoldbaum:phase-plot-colorbar branch Dec 11, 2018

ngoldbaum added a commit to ngoldbaum/yt that referenced this pull request Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.