ensure gadget binary field data are in native endianness #2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
force-pushed
the
bigendian-fix
branch
from
a054635
to
faf18b3
Compare
|
@ngoldbaum Whoa, this is great! Similar code may also be able to address the endian issues I described in PR #1944 ? If so, you just saved me a ton of time... |
ngoldbaum
changed the title
weiguangcui
approved these changes
Dec 12, 2018
There was a problem hiding this comment.
Hi all,
I have tested the code with both python2 and 3. All worked fine to me.
Thank you @ngoldbaum !
ngoldbaum
pushed a commit
to ngoldbaum/yt
that referenced
this pull request
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some low-level routines (in the test case in the bug report it was the selection machinery) expect raw field data from the low-level I/O routines to be in native byte order. However, here we're reading bigendian data and pass it directly to those low-level routines. This breaks on little endian architectures.
The fix is to ensure the data are in native byte order after we read it in.
Ping @weiguangcui and maybe @matthewturk to look this over?