Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: cleanup usage and mentions of deprecated material #3242

Merged
merged 1 commit into from May 18, 2021

Conversation

neutrinoceros
Copy link
Member

PR Summary

I discovered some deprecated functionalities are still used internally or documented as usable while they really aren't (add_volume_weighted_smoothed_field)

@neutrinoceros neutrinoceros added docs deprecation deprecate features or remove deprecated ones labels May 1, 2021
@neutrinoceros
Copy link
Member Author

neutrinoceros commented May 1, 2021

Failures on Jenkins are real. Some of the answer tests' names contains the name of a deprecated function set_window_size, so the newly named generated tests don't match any existing answer.
I read the docs in search for a solution and found
https://yt-project.org/doc/developing/testing.html#enabling-answer-tests-on-jenkins

If the answer doesn’t exist on the server yet, nosetests is run twice and during first pass --answer-store is added to the commandline.

which doesn't seem appropriate.
I'll try bumping the answers and hope it'll trigger regeneration.

update: yay, it worked !

@matthewturk matthewturk merged commit 2eb907e into yt-project:main May 18, 2021
@neutrinoceros neutrinoceros deleted the cleanup_depr_doc branch May 18, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation deprecate features or remove deprecated ones docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants