Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Introduce compatible-merge operators for format selection (was: Need a bestvideo+bestcompatibleaudio format selector) #10226
Comments
|
No, compatible-shortcuts is not a way to do. Compatibility is the characteristic of the merging operation not a particular format. Thus instead of introducing another n shortcuts an alternative compatible-merge-operator should be introduced. |
I guess you're referring to the compatibility of codecs. Yes, that's not wrong. I already see a TODO here. Maybe a |
|
I'm not referring to codecs. |
|
I'm too lazy to scour the source. Mind sharing a link to the code you're referring to? |
|
I'm not referring to any code. It's not implemented. |
|
Oh, my bad. Anyway, the point is, I am not talking specifically about the implementation of such a format selector. Rather, I am suggesting that we need a feature (maybe a new interface option) that lets us make |
|
You can already "block" mkv. You're just not reading the docs.
|
|
Wow! Either I am horrible at explaining things or you are not that great at understanding things. I read the docs and I am aware of that "blocking" strategy. My focus is NOT on blocking mkv, rather, it is on ensuring that video and audio files of compatible extensions are downloaded - for example, an m4a DASH video along with an mp4 DASH audio or a WebM DASH video along with a WebM DASH audio, NOT an mp4 DASH video along with a WebM DASH audio along, even if it is the best available audio format (which is usually the case with YouTube videos.) Preventing the muxing of incompatible files into an mkv is just the side effect. Did you at least read the title of the issue before commenting? This is what I am talking about, in pseudo-code:
|
|
@dstftw Did you mean something like this: |
Yes, that's the general idea.
For instance, by introducing another audio-plus-compatible-video-merge operator. |
|
Sounds good. |
Actually, @yan12125, |
|
Obviously we should have both since both scenarios are viable. |
|
Any plans to realize this awesome feature directly in the program? |
|
Also wishing for this. The merging of incompatible formats into mkv is great, but I'm finding that those files playback incorrectly in Chrome (but work fine in VLC). Of course this is not ytdl's fault, but still. |
I have
The purpose of this issue
Description
This request follows this question.
I need something like
-f bestvideo+bestcompatibleaudio, where'bestcompatibleaudio'is the selector for the best audio file which is compatible with the desired video file (so that the files don't need to be muxed into an mkv.) Or, if you all find this cool, maybe even'worstcompatibleaudio'Until it is implemented, anyone who is in dire need of this feature can use this script.