Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New regression: test_NationalGeographic #10229

Closed
anisse opened this issue Aug 5, 2016 · 2 comments
Closed

New regression: test_NationalGeographic #10229

anisse opened this issue Aug 5, 2016 · 2 comments

Comments

@anisse
Copy link
Contributor

@anisse anisse commented Aug 5, 2016

Commit 1891ea2 (ping @remitamine ) introduced regressions for test_NationalGeographic and test_NationalGeographic_1 .

See this build:
https://travis-ci.org/anisse/youtube-dl/jobs/149751474

FAIL: test_NationalGeographic_1 (test.test_download.TestDownload)

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/anisse/youtube-dl/test/test_download.py", line 187, in test_template

    self.assertTrue(os.path.exists(tc_filename), msg='Missing file ' + tc_filename)

AssertionError: Missing file 3TmMv9OvGwIR.mp4

@dstftw

@remitamine remitamine closed this in 5a993e1 Aug 5, 2016
@remitamine
Copy link
Collaborator

@remitamine remitamine commented Aug 5, 2016

it's not actually regression as i doesn't change the code of the old extractors i only changed the names of the extractors which make your script think that there is a regression.

@anisse
Copy link
Contributor Author

@anisse anisse commented Aug 5, 2016

Thanks, sorry for the false positives, interpretating the results is not always easy ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.