Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
MKV thumbnail not correctly embedded #10359
Comments
ghost
mentioned this issue
Sorry for being late. Which player are you using? |
|
I mainly use a software called Icaros which enables MKV files showing thumbnails in windows explorer using the thumbnail inside the file or, if there is no thumbnail inside it, using a generated one. But I see the same thing with Windows Media Player and VLC media player.
|
This reverts commit 7360db0. This commit was added as an attempt to fix #6046. Unfortunately, the fix is completely wrong. As reported on #10359, embedded thumbnails are not displayed in VLC, and Se7en on IRC reports that the embedded thumbnail misleads mpv as well. The correct way is using -attachment of ffmpeg, while the current run_ffmpeg_multiple_files API can't handle it cleanly.
|
Hi, you might be interested in merging https://github.com/Alex131089/youtube-dl/compare/Alex131089-mkv-thumbnail or https://github.com/Alex131089/youtube-dl/compare/Alex131089-mkv-thumbnail-filename, I was able to embed thumbnail without issue in VLC or MPC-HC with this. |
|
Awesome! Does it support non-ASCII thumbnail filenames? And I wonder how accurate |
No idea, but as much as for the MP3 I guess.
Mimetypes module seems to rely on the extension, so it's very "light". And with only 2 extensions recognized by the convention, I came with this much simpler version : https://github.com/Alex131089/youtube-dl/tree/Alex131089-mkv-thumbnail-simpler. |
|
This looks good, any reason it isn't merged yet? |
|
Any progress on this? I am also experiencing this bug. |
|
Any chance of merging this soon? |
What is the purpose of your issue?
When using --embed-thumbnail, it seems that the thumbnail isn't added as an image resource (cover.jpg) to the mkv video file but instead added as a second video stream. Seemingly using the same code as is used for embedding cover art for a mp3. This results in the embedded thumbnail not being displayed and instead no thumbnail or a automatically generated one being shown.
Tested with this video:
https://www.youtube.com/watch?v=k_okcNVZqqI
youtube-dl https://www.youtube.com/watch?v=k_okcNVZqqI --embed-thumbnail
Using youtube-dl 2016.08.13 and ffmpeg-20160815-3282e31-win64-static
MediaInfo, thumbnail embedded with --embed-thumbnail:
INK DROPS 4K (ULTRA HD)-k_okcNVZqqI.mkv.MediaInfo.txt
MediaInfo, thumbnail embedded with mkvpropedit:
INK DROPS 4K (ULTRA HD)-k_okcNVZqqI-proper.mkv.MediaInfo.txt
Related to this the request for thumbnail embedding support for webm files when this is fixed. (#10360)