Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code for --max-downloads #10388

Open
weedy opened this issue Aug 19, 2016 · 2 comments
Open

Exit code for --max-downloads #10388

weedy opened this issue Aug 19, 2016 · 2 comments

Comments

@weedy
Copy link

@weedy weedy commented Aug 19, 2016

As a unix user I fundamentally disagree with how #852 went but that's history now.

That said I can't imagine why you would want to exit non-zero when you use --max-downloads.

I wanted maximum 8 files, you gave me 8 files. Then exited with an error.
How does this make sense?

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Aug 21, 2016

As a reference, this "feature" is added in 94fd320. I guess it's because script writers need to know the reason of exiting. Ping @phihag.

By the way, --max-downloads violation has already a non-default exit code 101.

@ghost ghost mentioned this issue Jul 7, 2017
4 of 8 tasks complete
@tommcintyre
Copy link

@tommcintyre tommcintyre commented Jul 22, 2017

Agreed with @weedy, a nonzero exit code is not appropriate in this situation as I mentioned in another issue here: #13598 (comment)

A canonical way to do this could be via some stats/summary info, either printed out to the console or to a file in a computer-readable format; e.g. --write-summary-json wherever.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.