New signature algo doesn't work for length 86

[jaimeMF]

The test video for Vevo videos with age protection has length 86 and it's failing:

$y-dl "https://www.youtube.com/watch?v=07FYdnEawAQ"
[debug] System config: []
[debug] User config: ['--keep-video', '--verbose', '--write-info-json', '--write-thumbnail']
[debug] Command-line args: ['https://www.youtube.com/watch?v=07FYdnEawAQ']
[debug] youtube-dl version 2013.07.17
[debug] Git HEAD: f38de77
[debug] Python version 2.7.5 - Darwin-11.4.2-x86_64-i386-64bit
[debug] Proxy map: {}
[youtube] Setting language
[youtube] 07FYdnEawAQ: Downloading video webpage
[youtube] 07FYdnEawAQ: Downloading video info webpage
[youtube] Confirming age
[youtube] 07FYdnEawAQ: Extracting video information
[youtube] encrypted signature length 86 (42.43), itag 46, flash player vflncwGeR
[youtube] encrypted signature length 86 (42.43), itag 37, flash player vflncwGeR
[youtube] encrypted signature length 86 (42.43), itag 45, flash player vflncwGeR
[youtube] encrypted signature length 86 (42.43), itag 22, flash player vflncwGeR
[youtube] encrypted signature length 86 (42.43), itag 44, flash player vflncwGeR
[youtube] encrypted signature length 86 (42.43), itag 35, flash player vflncwGeR
[youtube] encrypted signature length 86 (42.43), itag 43, flash player vflncwGeR
[youtube] encrypted signature length 86 (42.43), itag 34, flash player vflncwGeR
[youtube] encrypted signature length 86 (42.43), itag 18, flash player vflncwGeR
[youtube] encrypted signature length 86 (42.43), itag 5, flash player vflncwGeR
[youtube] encrypted signature length 86 (42.43), itag 36, flash player vflncwGeR
[youtube] encrypted signature length 86 (42.43), itag 17, flash player vflncwGeR
[info] Video description metadata as JSON to: Justin Timberlake - Tunnel Vision (Explicit)-07FYdnEawAQ.mp4.info.json
[youtube] 07FYdnEawAQ: Downloading thumbnail ...
[youtube] 07FYdnEawAQ: Writing thumbnail to: Justin Timberlake - Tunnel Vision (Explicit)-07FYdnEawAQ.jpg
[download] Resuming download at byte 89364
ERROR: unable to download video
Traceback (most recent call last):
  File "/Users/{use}/Developer/proyectos/youtube-dl/youtube-dl/youtube_dl/YoutubeDL.py", line 573, in download
    videos = self.extract_info(url)
  File "/Users/{use}/Developer/proyectos/youtube-dl/youtube-dl/youtube_dl/YoutubeDL.py", line 327, in extract_info
    return self.process_ie_result(ie_result, download=download)
  File "/Users/{use}/Developer/proyectos/youtube-dl/youtube-dl/youtube_dl/YoutubeDL.py", line 410, in process_ie_result
    for r in ie_result['entries']
  File "/Users/{use}/Developer/proyectos/youtube-dl/youtube-dl/youtube_dl/YoutubeDL.py", line 357, in process_ie_result
    self.process_info(ie_result)
  File "/Users/{use}/Developer/proyectos/youtube-dl/youtube-dl/youtube_dl/YoutubeDL.py", line 550, in process_info
    raise UnavailableVideoError()
UnavailableVideoError

Also the tests for signatures fails (with don't they run in travis?):

./test/test_youtube_sig.py
FFFFFFFFF.
======================================================================
FAIL: test_43_43 (__main__.TestYoutubeSig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test/test_youtube_sig.py", line 19, in test_43_43
    self.assertEqual(sig(wrong), right)
AssertionError: 'CEAE0EC39677BC65FD9021CED115F1F2DBDEA59E4.C0B243A3E2DED6769199AF3461781E5512' != '931EA22157E1871643FA9519676DED253A342B0C.4E95A5DBD2F1F511DCC1209DF56CB77693CE0EAE'

======================================================================
FAIL: test_81 (__main__.TestYoutubeSig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test/test_youtube_sig.py", line 59, in test_81
    self.assertEqual(sig(wrong), right)
AssertionError: 'mrtyuioplkjhgfdsazxcvbne12345[7890QWERTYUIOPLKHGFDSAZXCVBNM!@#$%^&?(-+' != 'urty8ioplkjhgfdsazxcvbqm1234567e90QWERTYUIOPLKHGFDSnZXCVBNM!@#$%^&*(-+={[};?/>.'

======================================================================
FAIL: test_82 (__main__.TestYoutubeSig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test/test_youtube_sig.py", line 54, in test_82
    self.assertEqual(sig(wrong), right)
AssertionError: 'mrtyuioplkjhgfdsazxcvbne123456}890QWERTYUIOPLKHGFDSAZXCVBNM!@#$%^&*/-+=' != 'Q>/?;}[{=+-(*<^%$#@!MNBVCXZASDFGHKLPOIUY8REWT0q&7654321mnbvcxzasdfghjklpoiuytrew9'

======================================================================
FAIL: test_83 (__main__.TestYoutubeSig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test/test_youtube_sig.py", line 49, in test_83
    self.assertEqual(sig(wrong), right)
AssertionError: 'mrtyuioplkjhgfdsazxcvbne1234567}90QWERTYUIOPLKJHGFDSAZXCVBNM!#$%^&*(/_+=' != 'urty8ioplkjhgfdsazxcvbqm1234567S90QWERTYUIOPLKJHGFDnAZXCVBNM!#$%^&*()_+={[};?/>.<'

======================================================================
FAIL: test_84 (__main__.TestYoutubeSig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test/test_youtube_sig.py", line 44, in test_84
    self.assertEqual(sig(wrong), right)
AssertionError: 'mrtyuioplkjhgfdsazxcvbne12345678[0QWERTYUIOPLKJHGFDSAZXCVBNM!@#$%^&*(?_-+' != '<.>?;}[{=+-_)(*&^%$#@!MNBVCXZASDFGHJKLPOIUYTREWe098765432rmnbvcxzasdfghjklpoiuyt1'

======================================================================
FAIL: test_85 (__main__.TestYoutubeSig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test/test_youtube_sig.py", line 39, in test_85
    self.assertEqual(sig(wrong), right)
AssertionError: 'mrtyuioplkjhgfdsazxcvbne123456789}QWERTYUIOPLKJHGFDSAZXCVBNM!@#$%^&*()/-+=' != '{>/?;}[.=+-_)(*&^%$#@!MqBVCXZASDFwHJKLPOIUYTREWQ0987654321mnbvcxzasdfghjklpoiuytr'

======================================================================
FAIL: test_86 (__main__.TestYoutubeSig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test/test_youtube_sig.py", line 34, in test_86
    self.assertEqual(sig(wrong), right)
AssertionError: 'mrtyuioplkjhgfdsazxcvbne1234567890}WERTYUIOPLKJHGFDSAZXCVBNM!@#$%^&*()_/+={' != 'ertyuioplkjhgfdsazxcvbnm1234567890QWERTYUIOPLKJHGFDSAZXCVBNM!/#$%^&*()_-+={[|};?@'

======================================================================
FAIL: test_87 (__main__.TestYoutubeSig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test/test_youtube_sig.py", line 29, in test_87
    self.assertEqual(sig(wrong), right)
AssertionError: 'mrtyuioplkjhgfdsazxcvbne1234567890Q:ERTYUIOPLKJHGFDSAZXCVBNM!@#$^&*()_-+/{[]' != '!?;:|}][{=+-_)(*&^$#@/MNBVCXZASqFGHJKLPOIUYTREWQ0987654321mnbvcxzasdfghjklpoiuytr'

======================================================================
FAIL: test_88 (__main__.TestYoutubeSig)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./test/test_youtube_sig.py", line 24, in test_88
    self.assertEqual(sig(wrong), right)
AssertionError: 'mrtyuioplkjhgfdsazxcvbne1234567890QW:RTYUIOPLKJHGFDSAZXCVBNM!@#$%^&*()_-+/{[]' != 'J:|}][{=+-_)(*&;%$#@>MNBVCXZASDFGH^KLPOIUYTREWQ0987654321mnbvcxzasdfghrklpoiuytej'

----------------------------------------------------------------------
Ran 10 tests in 0.002s

FAILED (failures=9)

Maybe the new algotrithm doesn't work for all lengths.

[jaimeMF]

Adding the case for length 86 fixes the download problem

[phihag]

Yup, strange - I ran nosetests specifically to watch for the signature tests, but apparently, it doesn't recognize the signature tests. Will investigate ...

[jaimeMF]

We need to have the case for length 92, the normal vevo videos use it
About the sig tests, it has execution permissions, does nose run them?

[phihag]

Should be all fixed now. If not, please open a new issue.