TestDownload should allow running all tests for a given extractor

[johnhawkinson]

Please follow the guide below

• Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

• Feature request (request for a new functionality)

---

Description of your issue, suggested solution and other information

README/CONTRIBUTING explain:

6. Run python test/test_download.py TestDownload.test_YourExtractor. This should fail at first, but you can continually re-run it until you're done. If you decide to add more than one test, then rename _TEST to _TESTS and make it into a list of dictionaries. The tests will then be named TestDownload.test_YourExtractor, TestDownload.test_YourExtractor_1, TestDownload.test_YourExtractor_2, etc.

I have to admit, I read this, wrote one test, and later on went back and added some more tests but had forgotten the final sentence. I did not at first notice that I was only running the first test, and then it took me an embarassingly long time to figure out how to run the other tests.

Why is the code structured this way — shouldn't there be an easy way to run all tests for a given extractor? That would seem to be the common case if you're working on a single extractor?

Or maybe there is a way and I'm just not seeing it?

I haven't really wrapped my head around the testing framework code, so I don't have a patch, but I am a little mystified at the current structure? Thanks. Explanation appreciated.

[yan12125]

That's a good idea! Useful for handling big extractors like Twitter or Facebook.

FYI: test cases are generated dynamically in test/test_download.py.

[johnhawkinson]

When I found myself adding tests to the Generic Extractor this morning, I wished for this. Or a way to figure out that the test I was adding was test_Generic_25. I ended up counting the number of tests and guessing, which worked OK after an initial correction, but still seemed wrong.

Were there any thoughts on the pull request?

[yan12125]

Well, I just write a script to determine the ID for a given URL in generic.py.

[johnhawkinson]

Well, it's no good if the core maintainers have private tools to make your lives easier but the rest of us, who have less familiarity with the code, have to stumble around in the dark... :(

[yan12125]

I have quite a few shell scripts and I'll open pull requests for them.