Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream to a media player and close it, --frag* files not deleted and re-used #11054

Closed
jalba69 opened this issue Oct 28, 2016 · 8 comments
Closed

Comments

@jalba69
Copy link

@jalba69 jalba69 commented Oct 28, 2016

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like that [x])
  • Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.10.26. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

  • [x ] I've verified and I assure that I'm running youtube-dl 2016.10.26

Before submitting an issue make sure you have:

  • [ x] At least skimmed through README and most notably FAQ and BUGS sections
  • [ x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • [ x] Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • [ x] Feature request (request for a new functionality)
  • Question
  • Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue


If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:

Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):

$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.10.26
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

Hello,

Firs let me say thank you for this wonderful tool,

While using it to stream to a media player on some URL's it downloads --frag* files and if we stop the player for whatever reasons the --frag* files remain and are not deleted on exit.

Plus i noticed that if i use a different video URL on the same website the --frag* files already stored and not deleted will be used for the first part of the video in the media player, so i end up with a video having mixed content from 2 videos.

The --frag* files created during a stream to media player simply needs to be deleted once the application is closed.

Moreover we can't set the location path where we want to store those --frag* files, in my case i'd like to set them on my Ramdisk for multiples reasons :

For example I have a custom button on my browser toolbar that automatically copy the browser page URL and calls a batch file where the url is passed automatically to youtube-dl and the media streamed to MPC-HC, on a page having a video media i click the button on my toolbar and all is read in the media player, all this in a single click.

In this particular case when called from the browser with a batch file the --frag* files will be created ( and remain ) in my browser installation folder, not on the youtube-dl folder like when i call the program from there directly like i also do, in fact i call it from different programs to stream to MPC-HC and end up with --frag* files remaining and stored all over the place.

Plus using a Ramdisk for all those write/read small files will be a nice thing to speed up and ease the thing too.

Thanks a lot for your program, can't spend a day without using it :)

@DokVis
Copy link

@DokVis DokVis commented Nov 2, 2016

I'm having the same issue, would be nice if there was a commandline to delete the fragfiles when playing to a stream

@jalba69
Copy link
Author

@jalba69 jalba69 commented Nov 3, 2016

A i use mostly batch scripts to run the program embedded in various applications i added this at the end of all my batches for now :

If exist --frag* (goto delete) else (exit)
:delete
echo Deleting --Frag* files
del --Frag*

Still would like to see this automated as i still have some tools used in direct without batch scripts and the --frag* files are created and not removed automatically, need a manual cleanup or the first fragments already stored will be used for next stream to a media player, and more than anything i would like to see a possibility to set a folder to where all those --frag files go, would really like to be able to tell the program to use my Ramdisk for all this stuff.

Hopefully the guys working on this wonderful tool will have some time at some point to add such changes.

One can only hope ;)

@remitamine
Copy link
Collaborator

@remitamine remitamine commented Nov 3, 2016

Hopefully the guys working on this wonderful tool will have some time at some point to add such changes.

this problem should be fixed with #9937, it will remove the need for Frag files.

@jalba69
Copy link
Author

@jalba69 jalba69 commented Nov 3, 2016

Hello ,

Will the part of your code be merge with master project at some point ?
I'm not a coder, I use the .exe file for windows, don't have much clues about how things work inside github to merge branches or even compile myself an exe out of all this sadly :/

Your list of changes seems interesting and looks like it will solve the issues indeed, hope to see this added to main project soon.

Thank you

@remitamine
Copy link
Collaborator

@remitamine remitamine commented Nov 3, 2016

Will the part of your code be merge with master project at some point ?

it should be reviewed by another core developer before merging.

@jalba69
Copy link
Author

@jalba69 jalba69 commented Nov 3, 2016

Well... just need a bit of patience to see this fixed then i hope.

Thank you for your answers and hopefully your part of the code will make it soon into master branch.

@mpenkov
Copy link

@mpenkov mpenkov commented Aug 31, 2018

@jalba69 The pull request that @remitamine mentioned (#10993) got merged. It should fix your issue.

Can you please confirm whether it is still a problem?

@jalba69
Copy link
Author

@jalba69 jalba69 commented Dec 12, 2018

Sorry for the very late reply ( was not notified) , tested and it seems to work indeed, i see no more frag files remaining :)

thanks a lot and sorry again for the long delay in reply

@jalba69 jalba69 closed this Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.