Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
I've written a downloader for f4m manifests (the code is in this repo: https://github.com/jaimeMF/f4m-dl), I want to integrate this in the youtube-dl code. This is my proposal:
downloadermodule.FileDownloaderas the base class and move the HTTP file downloading code to a new method.YoutubeDLthat given an info dictionary decides which method it should call.'downloader': F4M_DOWNLOADER(whereF4M_DOWNLOADERis a constant from the downloader module)Instead of creating a new module and new classes it may be better to just add the f4m download process tas a new method, as with rtmp. But I think that all the flv handling code shouldn't be in
FileDownloader.py, that's why I prefer the other method, although this is simpler.There's also more reasons why I think is better to split the code in different classes:
progress_hookcalls, but the listener may only be interested in the final file progress, not the individual file.