Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: select bestaudio format based on determined bestvideo to preserve container type #11517

Closed
videonerd opened this issue Dec 23, 2016 · 2 comments
Labels

Comments

@videonerd
Copy link

@videonerd videonerd commented Dec 23, 2016

Previous topic was closed due to perceived availability of such a feature.

Present behaviour of bestaudio is independent of bestvideo. My feature request is for bestaudio to be dependent on the determined bestvideo format to preserve container format e.g:

if bestvideo is determined to be mp4, bestaudio will default to bestaudio[ext=m4a] to preserve the mp4 container and avoid an mkv output.

similarly, if bestvideo is determined to be vp9, bestaudio will default to bestaudio[ext=webm] to preserve the webm container and avoid an mkv output.

Thank you!

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Dec 23, 2016

Duplicate of #10226. There are some interesting discussions but no actual implementations yet.

@yan12125 yan12125 closed this Dec 23, 2016
@endquote
Copy link

@endquote endquote commented Feb 21, 2017

I attempted an implementation in JavaScript in response to @daemonster's Python version: https://gist.github.com/Daemonster/4c94372a85cd4b5ea86df06e102a19e7#gistcomment-2006531

@dstftw dstftw added the duplicate label Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.