Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Comcast_SSO failure with aetv #11538
Comments
|
This was fixed by @outcoldman: #11258 Wait till it gets merged, or you could always compile it yourself. |
|
I pulled the repo, applied the patch, compiled, and still have the issue. I think this is something different. Redacted version is here (removed e-mail and Name) |
|
This is what I get with the applied patch and your example link. I compiled youtube-dl 2016-12-22.
I downloaded the youtube-dl source code. Found and opened the file adobepass.py. Copy and pasted in the added lines of code by outcoldman. Then compiled and that solved my Comcast issues. I'm using Windows not Linux. Perhaps it is a different issue. Just wanted to point you to the fix in case it would help. |
|
I think my issue is different since I see the expected:
And I see my name & personal (non-comcast) e-mail in the login.comcast.net_login.dump. So I'm fairly confident I've been authenticated. From an internet search it seems that in some cases Comcast presents a Recovery Options page immediately after logging in (see: http://forums.xfinity.com/t5/Email-Web-Browsing/Recvery-Options-Page/td-p/2687138). What is strange is that I don't see this page when using a browser, just when using youtube-dl. The recovery options page (which I previously attached) contains a form, and one of the buttons is "askMeLater", so I think the solution to this issue is in adobepass.py after the login form is posted to add logic to check for the recovery page, i.e. just before the check for the "Resume" button, and submit the "askMeLater" form. But what I'm unsure of is how to populate the "data-tracking" portion of the button:
|
|
@jellofan so I know this isn't a permanent fix, but your issue is with the recovery options page. I had the same issue, if you have previously signed in and clicked remind me later you can't review the page on that user agent anymore. Comcast simply wont prompt you. A short term fix is to try signing in with a different browser, and thus a different agent, and verify your recovery options. It will no longer prompt you on any user agents including the one from youtubedl |
|
I'm having the same problem (with 2018.04.03), but on Cartoon Network. Could it be that there's a CAPTCHA on the Comcast login page that's not being filled out?
|
Actually that fix stopped working due to a minor URL change. For those running from source code or compiling your own, the quick fix for Comcast Xfinity is to use this version of adobepass.py: https://raw.githubusercontent.com/bhamboss/youtube-dl/patch-1/youtube_dl/extractor/adobepass.py That is from https://github.com/bhamboss/youtube-dl/blob/patch-1/youtube_dl/extractor/adobepass.py and I can confirm this works with Xfinity's new login if you are coming in from an Xfinity IP address. Just to be clear, Xfinity authenticates differently if you are coming in from one of their IP addresses vs. if you are coming in from the IP of some other provider. I tested the above patch coming from an Xfinity IP. I did NOT test it from another provider's IP. If I run diff -u on the original and patched files I get this:
|
|
Have you noticed the url change again with Comcast? |
Please follow the guide below
xinto all the boxes [ ] relevant to your issue (like that [x])Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2016.12.22. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue
If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add
-vflag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):Description of your issue, suggested solution and other information
Unable to download aetv.com videos using Comcast SSO. I tried several videos (including the one with --verbose info attached)