Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New regression: vimeo ondemand #11651

Closed
anisse opened this issue Jan 9, 2017 · 0 comments
Closed

New regression: vimeo ondemand #11651

anisse opened this issue Jan 9, 2017 · 0 comments

Comments

@anisse
Copy link
Contributor

@anisse anisse commented Jan 9, 2017

Since commit d8c507c (ping @remitamine ) there's a new regression for test VimeoOndemand (URL: https://vimeo.com/ondemand/20704). Output:

======================================================================
FAIL: test_VimeoOndemand (test.test_download.TestDownload)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/youtube-dl/test/test_download.py", line 199, in test_template
    format_bytes(got_fsize)))
  File "/youtube-dl/test/helper.py", line 236, in assertGreaterEqual
    self.assertTrue(got >= expected, msg)
nose.proxy.AssertionError: False is not true : Expected 105442900.mp4 to be at least 9.77KiB, but it's only 1.26KiB
-------------------- >> begin captured stdout << ---------------------
[vimeo:ondemand] 20704: Downloading webpage
[vimeo] 105442900: Downloading webpage
[vimeo] 105442900: Extracting information
[vimeo] 105442900: Downloading JSON metadata
[vimeo] 105442900: Downloading fastly_skyfire m3u8 information
[vimeo] 105442900: Downloading akfire_interconnect m3u8 information
[vimeo] 105442900: Downloading level3_skyfire_gce m3u8 information
[vimeo] 105442900: Downloading fastly_skyfire MPD information
[vimeo] 105442900: Downloading akfire_interconnect MPD information
[vimeo] 105442900: Downloading level3_skyfire_gce MPD information
[info] Writing video description metadata as JSON to: 105442900.info.json
[debug] Invoking downloader on 'https://05-lvl3-skyfire-gce.vimeocdn.com/1483970002-0561ab6f73839dddc41cb950d1ed03aec4ae279e/105442900/video/285405034,285405035,285405033/../'
[dashsegments] Total fragments: 1
[download] Destination: 105442900.mp4
[download] 100% of 1.26KiB in 00:00.14MiB/s ETA 00:00:00

--------------------- >> end captured stdout << ----------------------

File is now fetched in multiple fragments instead of one. The problem is the first fragment is only 1289 bytes.

Here are a few potential solutions:

  • fix md5, add a file_minsize of 1200, and fix test/test_download.py to have max(expected_minsize, 1000) instead of 10000 (ping @dstftw )
  • skip_download
  • have the --test mode fetch and agregate files until it reaches minsize, put correct md5.
@dstftw dstftw closed this in 1fd0fc4 Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.