Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo review IE broken config url #11821

Closed
davekaro opened this issue Jan 23, 2017 · 0 comments
Closed

Vimeo review IE broken config url #11821

davekaro opened this issue Jan 23, 2017 · 0 comments

Comments

@davekaro
Copy link

@davekaro davekaro commented Jan 23, 2017

  • I've verified and I assure that I'm running youtube-dl 2017.01.24
  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

$ python -m youtube_dl -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.01.24
[debug] Git HEAD: c3a65c3
[debug] Python version 2.7.12 - Darwin-16.3.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.1.3, ffprobe 3.1.3
[debug] Proxy map: {}
Usage: __main__.py [OPTIONS] URL [URL...]

__main__.py: error: You must provide at least one URL.
Type youtube-dl --help to see a list of all options.

Back in #10900 I discovered that Vimeo had started using React for the video review sites. They still are, but appear to now render more HTML on the server than they were initially. a093cfc fixed the issue by grabbing the configUrl out of the JSON in the source. However, now that attribute is gone from the source, but the original solution of grabbing it from the data-config-url in the HTML works again - because Vimeo sends that HTML from the server. So, simply reverting those few lines fixes the broken importer. However, maybe it's better to just add

if config_url is None:
    config_url = self._html_search_regex(
    r'data-config-url="([^"]+)"', webpage, 'config URL',
    default=NO_DEFAULT if video_password_verified else None)

in case Vimeo changes again?

@dstftw dstftw closed this in d61aa5e Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.