Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generic] False-positive Brightcove embed (was: Site Request: BoomerangTV.co.uk/videos) #12040

Closed
BridgeUK opened this issue Feb 9, 2017 · 1 comment
Labels
bug

Comments

@BridgeUK
Copy link

@BridgeUK BridgeUK commented Feb 9, 2017

  • I've verified and I assure that I'm running youtube-dl 2017.02.07
  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Site support request (request for adding support for a new site)

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:

Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):

youtube-dl.exe -v http://www.boomerangtv.co.uk/videos/tom-and-jerry-toothache
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'http://www.boomerangtv.co.uk/videos/tom-and-jerry-toothache']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2017.02.07
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
[generic] tom-and-jerry-toothache: Requesting header
WARNING: Falling back on generic information extractor.
[generic] tom-and-jerry-toothache: Downloading webpage
[generic] tom-and-jerry-toothache: Extracting information
[generic] Brightcove video detected.
[download] Downloading playlist: Toothache| Tom and Jerry Videos | Boomerang
[generic] playlist Toothache| Tom and Jerry Videos | Boomerang: Collected 1 vide
o ids (downloading 1 of them)
[download] Downloading video 1 of 1
[brightcove:legacy] ' + video_url + ': Downloading webpage
ERROR: brightcove said: This player is not enabled for access without key.
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\YoutubeDL.py", line 696, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\extractor\common.py", line 369, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\extractor\brightcove.py", line 277, in _real_extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\extractor\brightcove.py", line 300, in _get_video_info
youtube_dl.utils.ExtractorError: brightcove said: This player is not enabled for
 access without key.
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.


Description of your issue, suggested solution and other information

I'd like to make request for boomerangtv.co.uk/videos please, it's a UK based website, thank you.

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Feb 17, 2017

A workaround:

diff --git a/youtube_dl/extractor/generic.py b/youtube_dl/extractor/generic.py
index 3db31debe..561d76350 100644
--- a/youtube_dl/extractor/generic.py
+++ b/youtube_dl/extractor/generic.py
@@ -1809,23 +1809,6 @@ class GenericIE(InfoExtractor):
             return self.playlist_result(
                 urlrs, playlist_id=video_id, playlist_title=video_title)
 
-        # Look for Brightcove Legacy Studio embeds
-        bc_urls = BrightcoveLegacyIE._extract_brightcove_urls(webpage)
-        if bc_urls:
-            self.to_screen('Brightcove video detected.')
-            entries = [{
-                '_type': 'url',
-                'url': smuggle_url(bc_url, {'Referer': url}),
-                'ie_key': 'BrightcoveLegacy'
-            } for bc_url in bc_urls]
-
-            return {
-                '_type': 'playlist',
-                'title': video_title,
-                'id': video_id,
-                'entries': entries,
-            }
-
         # Look for Brightcove New Studio embeds
         bc_urls = BrightcoveNewIE._extract_urls(webpage)
         if bc_urls:
@yan12125 yan12125 changed the title Site Request: BoomerangTV.co.uk/videos [generic] False-positive Brightcove embed (was: Site Request: BoomerangTV.co.uk/videos) Feb 17, 2017
@yan12125 yan12125 added the bug label Feb 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.