Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1080p support for Hotstar #12096

Closed
johnsmathew opened this issue Feb 12, 2017 · 6 comments
Closed

1080p support for Hotstar #12096

johnsmathew opened this issue Feb 12, 2017 · 6 comments
Assignees
Labels

Comments

@johnsmathew
Copy link

@johnsmathew johnsmathew commented Feb 12, 2017

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like that [x])
  • Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.02.11. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2017.02.11

Before submitting an issue make sure you have:

  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

Hotstar shows upto 720p videos on their website and youtube-dl supports all of them. However, modifying the m3u8 file url gives 1080p videos. Does adding support to download a higher quality video than the ones provided in the original website violates any of the terms of youtube-dl?

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Feb 12, 2017

modifying the m3u8 file url gives 1080p videos

Please give an example video and how to do such a modification

@johnsmathew
Copy link
Author

@johnsmathew johnsmathew commented Feb 12, 2017

Modifying the format_url as follows after getting it from format_data['src']

format_url = re.sub(r'(_STAR.mp4)', r'3000,4500,\1', format_url)

youtube-dl then lists 1080p with the available video formats.

Sample hotstar link : http://www.hotstar.com/movies/singham/1000065774

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Feb 12, 2017

Interesting. How did you find this hack?

@johnsmathew
Copy link
Author

@johnsmathew johnsmathew commented Feb 12, 2017

Today I had to download few videos from hotstar and found this in a forum. This has been around for over an year. But everyone suggested manually modifying the link and using ffmpeg to capture the stream. I tried modifying youtube-dl and it worked. So I thought I would share it here.

@yan12125
Copy link
Collaborator

@yan12125 yan12125 commented Feb 12, 2017

It's OK to add dirty heuristics, just need to check URLs with _is_valid_url

@yan12125 yan12125 added the request label Feb 12, 2017
@remitamine remitamine self-assigned this Feb 12, 2017
@johnsmathew johnsmathew mentioned this issue Feb 12, 2017
4 of 8 tasks complete
@johnsmathew
Copy link
Author

@johnsmathew johnsmathew commented Feb 12, 2017

Please see this PR #12098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.