Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce playlist level thumbnail and write it with --write-thumbnail #12146

Open
BridgeUK opened this issue Feb 15, 2017 · 10 comments
Open

Introduce playlist level thumbnail and write it with --write-thumbnail #12146

BridgeUK opened this issue Feb 15, 2017 · 10 comments
Labels

Comments

@BridgeUK
Copy link

@BridgeUK BridgeUK commented Feb 15, 2017

  • I've verified and I assure that I'm running youtube-dl 2017.02.16
  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones
  • Feature request (request for a new functionality)

Description of your issue, suggested solution and other information

I'd like to request a feature please, the feature is --write-artwork for crunchyroll, for example if you type youtube-dl.exe --write-artwork http://www.crunchyroll.com/naruto-shippuden it will also download the artwork from the right hand side http://img1.ak.crunchyroll.com/i/spire1/958243dc68ae929a6b9cb834165112471456969325_full.jpg

thank you

@mcerdeira
Copy link

@mcerdeira mcerdeira commented Feb 15, 2017

Hi, if this resquest is aligned with the project guidelines and milestones, I would like to adress it.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Feb 15, 2017

Implementing this feature requires introducing a new playlist level meta field first. Second, there is no point in this option at all - there is already --write-thumbnail exists.

@BridgeUK
Copy link
Author

@BridgeUK BridgeUK commented Feb 15, 2017

@dstftw --write-thumbnail only downloads the thumbnail for the episode, by using --write-artwork for a playlist it would download the artwork for the playlist.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Feb 15, 2017

Once again: there is no need in another option. Existing one should just write playlist's thumbnail.

@BridgeUK
Copy link
Author

@BridgeUK BridgeUK commented Feb 15, 2017

@dstftw when I tried --write-thumbnail earlier it only downloaded the episode thumbnail not the playlist artwork.

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Feb 15, 2017

Did you even read my posts? It's not implemented.

@BridgeUK
Copy link
Author

@BridgeUK BridgeUK commented Feb 15, 2017

@dstftw my mistake sorry, when you said "Existing one should just write playlist's thumbnail" I thought I had missed something on my end when using the command.

@BridgeUK
Copy link
Author

@BridgeUK BridgeUK commented Feb 15, 2017

@dstftw to me --write-artwork would be a very useful feature.

@dstftw dstftw changed the title Feature Request: [--write-artwork] crunchyroll Introduce playlist level thumbnail and write it with --write-thumbnail Feb 16, 2017
@yan12125 yan12125 added the request label Feb 22, 2017
@BridgeUK
Copy link
Author

@BridgeUK BridgeUK commented May 14, 2017

@mcerdeira are you able to complete this, please?

Thanks!

@BridgeUK
Copy link
Author

@BridgeUK BridgeUK commented Jun 28, 2017

if anyone has the time to complete this it would be most appreciated, thank you very much 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.