Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify mp3 quality and prevent the video from being deleted #123

Closed
rmanola opened this issue Jun 4, 2011 · 1 comment
Closed

Comments

@rmanola
Copy link
Contributor

@rmanola rmanola commented Jun 4, 2011

When specifying the --extract-audio option with MP3 format, it extracts the audio to 128K by default. It doesn't allow to specify the quality. I know that with aac it extracts the highest audio quality, but I needed the Mp3 format. Also, by default, it automatically erases the video file after conversion.

The request here is to keep these defaults and allow these missing features. I have done a patch that implement them:
http://pastebin.com/EByKyVFB

@rmanola rmanola closed this Jun 7, 2011
@rmanola rmanola reopened this Jun 7, 2011
@rmanola
Copy link
Contributor Author

@rmanola rmanola commented Jun 7, 2011

I have created a branch and submited the code with a pull request. I guess this thread isn't needed anymore...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.