Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Signature descriptions on demand #1241

Closed
newzealandpaul opened this issue Aug 14, 2013 · 6 comments
Closed

Request: Signature descriptions on demand #1241

newzealandpaul opened this issue Aug 14, 2013 · 6 comments

Comments

@newzealandpaul
Copy link

@newzealandpaul newzealandpaul commented Aug 14, 2013

youtube-dl devs you are doing an excellent job, but it seems everytime I use youtube-dl, VEVO has changed the signatures. If Youtube and VEVO are playing a game of whack-a-mole with us, we need to move quicker.

Would it not be easier to have a signature description file that could be downloaded automatically (or automatically if the correct option is passed to youtube-dl) from youtube-dl.org when it is unable to deal with an encrypted signature. The description file could be updated more frequently than the rest of the code base.

Just an idea ... keep up the great work.

@awojnowski
Copy link
Contributor

@awojnowski awojnowski commented Aug 14, 2013

Whenever the signature is changed, a corresponding patch is released within a few hours. The speed of the fix would probably be the same regardless of whether the signature was fixed in the codebase or on an external area. Right now, in the current case, it seems a little slow merging the fix for the signature, but in the future fixes should be fast enough that you can just update before running and not experience any adverse behaviour (unless you just get really unlucky). I suppose, however, that it may be easier to have the signature decryption code on an external source so updating isn't required as often.

@newzealandpaul
Copy link
Author

@newzealandpaul newzealandpaul commented Aug 14, 2013

Ok, cool. Thanks.

On Wed, Aug 14, 2013 at 5:37 PM, Aaron Wojnowski
notifications@github.comwrote:

Whenever the signature is changed, a corresponding patch is released
within a few hours. The speed of the fix would probably be the same
regardless of whether the signature was fixed in the codebase or on an
external area. Right now, in the current case, it seems a little slow
merging the fix for the signature, but in the future fixes should be fast
enough that you can just update before running and not experience any
adverse behaviour (unless you just get really unlucky).


Reply to this email directly or view it on GitHubhttps://github.com//issues/1241#issuecomment-22615976
.

@sulge
Copy link

@sulge sulge commented Aug 14, 2013

I provide code which not need to be updated when YouTube player has been changed, this code works very well in my project. But for some reason yt-dl devs did not wont use it. Maybe they like when users thanks them after each update?

Here is my code based on information provided by @patrickslin:
#1208

@newzealandpaul
Copy link
Author

@newzealandpaul newzealandpaul commented Aug 14, 2013

@sulge I really hope your code is integrated. You only submitted the code a week ago, give them time to take a look at it.

@phihag
Copy link
Contributor

@phihag phihag commented Aug 14, 2013

@sulge There is no conspiracy theory of the developers not liking it. The code just has to be cleaned up (no prints, for example, and no useless comments, and multithreading ability, etc.), thoroughly tested (say, on Python 3 as well), and then integrated, all of which takes time.

@phihag phihag closed this Aug 14, 2013
@sulge
Copy link

@sulge sulge commented Aug 14, 2013

Some, comment from me:

  • no prints - you can use replace function available in each text editor
  • no useless comments just delete them all if you do not like comment
  • multithreading ability - no need each thread can create instance of this class for it self, then it will be thread safety
  • thoroughly tested (say, on Python 3 as well) - hmm correct me but in this project the best testers are users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.