Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Subtitles are removed when "[ffmpeg] Adding metadata" is called after "[ffmpeg] Embedding subtitles" although the order is different in my youtube-dl.conf #12423
Comments
sebma
changed the title
yan12125
added a commit
that referenced
this issue
Mar 11, 2017
The previous fix for #5594 is incorrect
|
Thanks for the report. This is a regression after my previous incorrect fix for #5594. In the next version both cases should work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please follow the guide below
xinto all the boxes [ ] relevant to your issue (like that [x])Make sure you are using the latest version: run
youtube-dl --versionand ensure your version is 2017.03.10. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.Before submitting an issue make sure you have:
What is the purpose of your issue?
The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue
If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add
-vflag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):
Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
Description of your issue, suggested solution and other information
Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
Hi,
Subtitles are remove when "[ffmpeg] Adding metadata" is called after "[ffmpeg] Embedding subtitles" although the order is different in my youtube-dl.conf :
Can you please try and fix this ?