Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m4a thumbnail and metadata not working together #12429

Closed
Fight-Cloud opened this issue Mar 12, 2017 · 1 comment
Closed

m4a thumbnail and metadata not working together #12429

Fight-Cloud opened this issue Mar 12, 2017 · 1 comment

Comments

@Fight-Cloud
Copy link

@Fight-Cloud Fight-Cloud commented Mar 12, 2017

Please follow the guide below

  • You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your issue (like that [x])
  • Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.03.10. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

  • I've verified and I assure that I'm running youtube-dl 2017.03.10

Before submitting an issue make sure you have:

  • At least skimmed through README and most notably FAQ and BUGS sections
  • Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

  • Bug report (encountered problems with youtube-dl)
  • Site support request (request for adding support for a new site)
  • Feature request (request for a new functionality)
  • Question
  • Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue


If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:

Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
m4a console output:

C:\Users\Bert\Music\Ripped>youtube-dl -v https://www.youtube.com/watch?v=vkOJ9uN
j9EY
[debug] System config: []
[debug] User config: ['--youtube-skip-dash-manifest', '--format', 'm4a', '--meta
data-from-title', '%(artist)s - %(title)s', '--embed-thumbnail', '--add-metadata
', '-o', 'C:/Users/Bert/Music/Ripped/%(title)s.%(ext)s']
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.youtube.com/watch?v=vkOJ9uNj9EY']

[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2017.03.10
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-83781-g3016e91, ffprobe N-83781-g3016e91
[debug] Proxy map: {}
[youtube] vkOJ9uNj9EY: Downloading webpage
[youtube] vkOJ9uNj9EY: Extracting video information
[youtube] {22} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {43} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {18} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {36} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {17} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {136} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {247} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {135} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {244} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {134} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {243} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {133} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {242} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {160} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {278} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {140} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {171} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {249} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {250} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {251} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] vkOJ9uNj9EY: Downloading thumbnail ...
[youtube] vkOJ9uNj9EY: Writing thumbnail to: C:\Users\Bert\Music\Ripped\DMX - X
Gon Give It To Ya (Dirty).jpg
[debug] Invoking downloader on 'https://r1---sn-gvbxgn-t34e.googlevideo.com/vide
oplayback?sparams=clen%2Cdur%2Cei%2Cgir%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%
2Ckeepalive%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Crequiressl%2Csource%2Cupn%2C
expire&mime=audio%2Fmp4&key=yt6&expire=1489296399&dur=215.852&lmt=14582176914628
68&keepalive=yes&itag=140&requiressl=yes&clen=3428931&upn=n6vJCnQWy4U&ipbits=0&p
l=17&ei=r4fEWLq-F8bouQKQ9onoDQ&source=youtube&ip=99.237.166.10&ms=au&mt=14892747
20&mv=m&id=o-AIzEL6WJwyl2bAOBKsWivrBRcrFNVfbrmc7tC1xT6u2x&mm=31&gir=yes&mn=sn-gv
bxgn-t34e&beids=%5B9465691%5D&initcwndbps=2336250&signature=AA1F61F9E73F84303F7C
D254A0B706F81F53B05A.E2B31AABE0118964BEF9180A43BDC4671F8B3AEA&ratebypass=yes'
[download] Destination: C:\Users\Bert\Music\Ripped\DMX - X Gon Give It To Ya (Di
rty).m4a
[download] 100% of 3.27MiB in 00:01
[ffmpeg] Correcting container in "C:\Users\Bert\Music\Ripped\DMX - X Gon Give It
 To Ya (Dirty).m4a"
[debug] ffmpeg command line: ffmpeg -y -i 'file:C:\Users\Bert\Music\Ripped\DMX -
 X Gon Give It To Ya (Dirty).m4a' -c copy -f mp4 'file:C:\Users\Bert\Music\Rippe
d\DMX - X Gon Give It To Ya (Dirty).temp.m4a'
[fromtitle] parsed artist: DMX
[fromtitle] parsed title: X Gon Give It To Ya (Dirty)
[atomicparsley] Adding thumbnail to "C:\Users\Bert\Music\Ripped\DMX - X Gon Give
 It To Ya (Dirty).m4a"
[debug] AtomicParsley command line: AtomicParsley 'C:\Users\Bert\Music\Ripped\DM
X - X Gon Give It To Ya (Dirty).m4a' --artwork 'C:\Users\Bert\Music\Ripped\DMX -
 X Gon Give It To Ya (Dirty).jpg' -o 'C:\Users\Bert\Music\Ripped\DMX - X Gon Giv
e It To Ya (Dirty).temp.m4a'
[ffmpeg] Adding metadata to 'C:\Users\Bert\Music\Ripped\DMX - X Gon Give It To Y
a (Dirty).m4a'
[debug] ffmpeg command line: ffmpeg -y -i 'file:C:\Users\Bert\Music\Ripped\DMX -
 X Gon Give It To Ya (Dirty).m4a' -vn -acodec copy -metadata 'comment=Like the F
acebook page - http://www.facebook.com/Gangsta.G.Rap' -metadata 'title=X Gon Giv
e It To Ya (Dirty)' -metadata 'purl=https://www.youtube.com/watch?v=vkOJ9uNj9EY'
 -metadata date=20120827 -metadata artist=DMX -metadata 'description=Like the Fa
cebook page - http://www.facebook.com/Gangsta.G.Rap' 'file:C:\Users\Bert\Music\R
ipped\DMX - X Gon Give It To Ya (Dirty).temp.m4a'
...
<end of log>

mp3 console output:


C:\Users\Bert\Music\Ripped>youtube-dl --ignore-config --extract-audio --audio-f
rmat mp3 --audio-quality 0 --no-part --no-mtime --embed-thumbnail --metadata-fr
m-title "%(artist)s - %(title)s" --add-metadata https://www.youtube.com/watch?v
vkOJ9uNj9EY -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--ignore-config', '--extract-audio', '--audio-form
t', 'mp3', '--audio-quality', '0', '--no-part', '--no-mtime', '--embed-thumbnai
', '--metadata-from-title', '%(artist)s - %(title)s', '--add-metadata', 'https:
/www.youtube.com/watch?v=vkOJ9uNj9EY', '-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2017.03.10
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-83781-g3016e91, ffprobe N-83781-g3016e91
[debug] Proxy map: {}
[youtube] vkOJ9uNj9EY: Downloading webpage
[youtube] vkOJ9uNj9EY: Downloading video info webpage
[youtube] vkOJ9uNj9EY: Extracting video information
[youtube] {22} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {43} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {18} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {36} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {17} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {136} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {247} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {135} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {244} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {134} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {243} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {133} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {242} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {160} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {278} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {140} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {171} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {249} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {250} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {251} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] vkOJ9uNj9EY: Downloading thumbnail ...
[youtube] vkOJ9uNj9EY: Writing thumbnail to: DMX - X Gon Give It To Ya (Dirty)-
kOJ9uNj9EY.jpg
[debug] Invoking downloader on 'https://r1---sn-tt17rn7r.googlevideo.com/videop
ayback?source=youtube&mt=1489275983&mv=m&keepalive=yes&ei=qYzEWLf0BtDKuAKMqbioD
&ms=au&ip=99.237.166.10&lmt=1458217691462868&dur=215.852&pl=17&mm=31&mn=sn-tt17
n7r&id=o-AIxWgtWpdk2QPnhcO-soByiIGvTdAZPVDrDf3zh3zq1V&clen=3428931&requiressl=y
s&itag=140&initcwndbps=1411250&mime=audio%2Fmp4&ipbits=0&gir=yes&key=yt6&upn=ms
7bnCrKXM&sparams=clen%2Cdur%2Cei%2Cgir%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%
Ckeepalive%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Crequiressl%2Csource%2Cupn%2C
xpire&expire=1489297673&signature=56CD76259EC84F67AC709BDE60AE174ECECB2CB6.DB2D
2838A1E233179206345012D93BCF0C111CE&ratebypass=yes'
[download] Destination: DMX - X Gon Give It To Ya (Dirty)-vkOJ9uNj9EY.m4a
[download] 100% of 3.27MiB in 00:00
[ffmpeg] Correcting container in "DMX - X Gon Give It To Ya (Dirty)-vkOJ9uNj9EY
m4a"
[debug] ffmpeg command line: ffmpeg -y -i 'file:DMX - X Gon Give It To Ya (Dirt
)-vkOJ9uNj9EY.m4a' -c copy -f mp4 'file:DMX - X Gon Give It To Ya (Dirty)-vkOJ9
Nj9EY.temp.m4a'
[fromtitle] parsed artist: DMX
[fromtitle] parsed title: X Gon Give It To Ya (Dirty)
[debug] ffmpeg command line: ffprobe -show_streams 'file:DMX - X Gon Give It To
Ya (Dirty)-vkOJ9uNj9EY.m4a'
[ffmpeg] Destination: DMX - X Gon Give It To Ya (Dirty)-vkOJ9uNj9EY.mp3
[debug] ffmpeg command line: ffmpeg -y -i 'file:DMX - X Gon Give It To Ya (Dirt
)-vkOJ9uNj9EY.m4a' -vn -acodec libmp3lame -q:a 0 'file:DMX - X Gon Give It To Y
 (Dirty)-vkOJ9uNj9EY.mp3'
Deleting original file DMX - X Gon Give It To Ya (Dirty)-vkOJ9uNj9EY.m4a (pass
k to keep)
[ffmpeg] Adding thumbnail to "DMX - X Gon Give It To Ya (Dirty)-vkOJ9uNj9EY.mp3

[debug] ffmpeg command line: ffmpeg -y -i 'file:DMX - X Gon Give It To Ya (Dirt
)-vkOJ9uNj9EY.mp3' -i 'file:DMX - X Gon Give It To Ya (Dirty)-vkOJ9uNj9EY.jpg'
c copy -map 0 -map 1 -metadata:s:v 'title="Album cover"' -metadata:s:v 'comment
"Cover (Front)"' 'file:DMX - X Gon Give It To Ya (Dirty)-vkOJ9uNj9EY.temp.mp3'
[ffmpeg] Adding metadata to 'DMX - X Gon Give It To Ya (Dirty)-vkOJ9uNj9EY.mp3'
[debug] ffmpeg command line: ffmpeg -y -i 'file:DMX - X Gon Give It To Ya (Dirt
)-vkOJ9uNj9EY.mp3' -c copy -metadata 'purl=https://www.youtube.com/watch?v=vkOJ
uNj9EY' -metadata artist=DMX -metadata date=20120827 -metadata 'title=X Gon Giv
 It To Ya (Dirty)' -metadata 'description=Like the Facebook page - http://www.f
cebook.com/Gangsta.G.Rap' -metadata 'comment=Like the Facebook page - http://ww
.facebook.com/Gangsta.G.Rap' 'file:DMX - X Gon Give It To Ya (Dirty)-vkOJ9uNj9E
.temp.mp3'
...
<end of log>

Description of your issue, suggested solution and other information

My issue is similar to this issue except I am using the m4a format. When I try to add thumbnail and metadata the thumbnail is not added, but when I add just the thumbnail it works fine. It also doesn't work with mp3 files. Any help is appreciated, thanks in advance!

@dstftw
Copy link
Collaborator

@dstftw dstftw commented Mar 12, 2017

This is already fixed.

@dstftw dstftw closed this Mar 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.